Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[CVP] [$250] Free trial of workspace mentioned in welcome message when user have no workspace #46338

Closed m-natarajan closed 2 months ago

m-natarajan commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.13-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722036482639849

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account and select Track in onboarding
  3. Click the global + > Track
  4. Choose the Submit to someone actionable mention

Expected Result:

No mention about free trial workspace in concierge message

Actual Result:

Mentioned about workspace in the message even if the user not created a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/527eb864-77f2-427c-8a62-3721bebf7913

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aa51c694d41de340
  • Upwork Job ID: 1818323017692441626
  • Last Price Increase: 2024-08-06
Issue OwnerCurrent Issue Owner: @situchan
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01aa51c694d41de340

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

situchan commented 3 months ago

Awaiting proposals

VincentCorleone commented 3 months ago

I think it is a backend issue

melvin-bot[bot] commented 2 months ago

@abekkala, @situchan Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 2 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

trjExpensify commented 2 months ago

I can only repro this in the Track > Submit someone flow:

https://github.com/user-attachments/assets/0647fd64-0e7a-4cb8-87bc-ab98e15adf29

Looks like we call OpenWorkspace in the ConvertedTrackedExpenseToRequest flow (logs for that API call), and I'm not sure why @thienlnam?

OpenWorkspace Logs

[104.28.159.59->/api.php] Malformed REQUEST: 'policyID' = '-1', ignoring (should match '[A-F0-9]+').

CC: @chiragsalian for visibility on free trial stuff.

chiragsalian commented 2 months ago

This looks like an internal bug. Looks like jack's already got a PR for this.

trjExpensify commented 2 months ago

Auth and Web PRs for this now merged, awaiting deploys.

danielrvidal commented 2 months ago

Doe this still need to be open? It looks like they both merged above.

thienlnam commented 2 months ago

Yup, looks resolved now