search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[payment due 9/10][$250] IOU - Distance tab flickering to manual & back to distance every time when add destination #46346

Open lanitochka17 opened 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.13-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): gocemate+a753@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Login with gmail account
  2. Go to FAB> Submit Expense> Distance
  3. Add a start destination> Your location
  4. Check tabs (manual, scan, distance) behavior
  5. Add stop destination
  6. Check tabs (manual, scan, distance) behavior

Expected Result:

Distance tab should remain since we work on that tab

Actual Result:

Distance tab switch to manual and back to distance every time when add destination

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/f07d9d5c-a93a-4c22-9df8-f10c49633c19

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b7f69f2e00762143
  • Upwork Job ID: 1817973479806682768
  • Last Price Increase: 2024-08-08
Issue OwnerCurrent Issue Owner: @cdOut
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

We think that this bug might be related to #vip-vip

lanitochka17 commented 1 month ago

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Christinadobrzyn commented 1 month ago

I can reproduce this - only seems to be affecting Android web app. I think this can be external. I think this might be part of Collect since it's a distance expense.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~01b7f69f2e00762143

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

Christinadobrzyn commented 1 month ago

waiting on proposals

Christinadobrzyn commented 1 month ago

I'll see if someone at SWM would want this. https://expensify.slack.com/archives/C04878MDF34/p1722447232998509

cdOut commented 1 month ago

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’m going to be working on this task.

Christinadobrzyn commented 1 month ago

Awesome! Thank you @cdOut! I've assigned you to the GH.

VincentCorleone commented 1 month ago

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’m going to be working on this task.

@cdOut So can external contributors submit a proposal and get paid from upwork?

cdOut commented 1 month ago

@VincentCorleone I'm taking over this issue so no, there is no need for proposals.

cdOut commented 1 month ago

I'm still figuring it out, PR should be up today or tomorrow.

cdOut commented 1 month ago

Had a slight delay by another issue getting unblocked by backend merges, will continute today.

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Christinadobrzyn commented 1 month ago

Hi @cdOut just checking in on this to see you have an update before the weekend. Thank you!

cdOut commented 1 month ago

I'm working on the PR for this issue, draft will be up early next week.

melvin-bot[bot] commented 1 month ago

@mananjadhav @Christinadobrzyn @cdOut this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

cdOut commented 1 month ago

cc: @Christinadobrzyn @mananjadhav

We've investigated this issue further and discovered that it not only affects other platforms (page rendering on web and desktop is smoother, which is why it's difficult to catch the flicker as it happens very quickly) but also impacts the Start chat flow, since it uses the same components.

We have identified a working fix: the problem appears to reside in the react-native-tab-view library. This library makes the selected tab index dependent on the view layout, and the view returns a width and height of 0 for a split second when navigating to a page containing the top bar, before obtaining the correct dimensions from an event listener. This results in it always pointing to the first element no matter which one is actually selected for that split second.

I will search for a way to fix this within our codebase rather than relying on an external library. If that proves unfeasible, I will create a PR to address this issue in the library and proceed to implement a temporary patch in our codebase.

Christinadobrzyn commented 1 month ago

Hi @cdOut - thank you for the thorough update! Please keep us in the loop and let us know if you need anything!

melvin-bot[bot] commented 4 weeks ago

@mananjadhav, @Christinadobrzyn, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

Christinadobrzyn commented 4 weeks ago

Update for Melvin - @cdOut is searching for a fix based on this update.

Can you let us know if there's more of an update @cdOut?

Christinadobrzyn commented 3 weeks ago

I'm just checking in on this @cdOut. If you can provide an update, that would be great! Thank you!

melvin-bot[bot] commented 3 weeks ago

@mananjadhav, @Christinadobrzyn, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

cdOut commented 3 weeks ago

@Christinadobrzyn I'm going to be raising a draft PR with a fix patch for it in a moment.

Christinadobrzyn commented 2 weeks ago

Hi, @cdOut, I'm just checking on this to see if you have any specific updates - otherwise, it looks like the PR is in the works!

cdOut commented 2 weeks ago

No update needed, PR with the patch is being tested by Manan.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

thienlnam commented 2 weeks ago

Just merged the PR, but let's keep this issue open until we get the patch removed with an upstream PR

Christinadobrzyn commented 1 week ago

PR deployed to production yesterday - https://github.com/Expensify/App/pull/47885 so adding the payment date to the subject.

I'm going to be ooo 9/4 - 9/10 so I'll plan on paying this when I'm back - if that's okay.

Do we need a regression? @mananjadhav are you paid through NewDot?

Payouts due:

cdOut commented 1 week ago

Please check the conversation in the PR itself here, this patch sadly broke another functionality that we didn't catch during testing so we had to revert it.

I'm going to be working on a fix that doesn't break the tab drag changing animation so please keep this issue open until a new PR gets merged.

cdOut commented 2 days ago

Hi, wanted to update this issue. I currently have to focus on other more important issues and I will pick this issue back up early next week.

mananjadhav commented 2 days ago

Thanks for the update @cdOut. Is there someone else who can pick this up? or you'll pick this once you're done with the other PRs?

cdOut commented 2 days ago

I'll pick it up after I'm done with the other PRs.

Christinadobrzyn commented 2 days ago

I'm back - looks like we're working on another PR? @cdOut can you provide the new PR to follow?

cdOut commented 2 days ago

It's not raised yet, I'll let you know when I create it.