search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

Web - Editing Mentioned Emails Displays Only Edited Words in LHN #46415

Open lanitochka17 opened 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.13-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to self DM
  2. Write two mentioned emails side by side
  3. Send the message
  4. Edit the second mentioned email by replacing it with words

Expected Result:

The mentioned email, now edited to words, should be displayed in the LHN as it appears in the composer

Actual Result:

When writing two mentioned emails side by side and editing the second mentioned email to words, only the words are displayed in the LHN. This creates an inconsistency between the edited message and the directly sent message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/158f1c6a-1a4c-4c02-9266-b62729b307a6

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

FitseTLT commented 1 month ago

BE issue

melvin-bot[bot] commented 1 month ago

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

RachCHopkins commented 1 month ago

Not understanding why someone would @ tag anyone in a DM with themselves.

Does this happen without @ tagging?

melvin-bot[bot] commented 1 month ago

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

RachCHopkins commented 1 month ago

Checking in the bug channel.

RachCHopkins commented 1 month ago

I don't think this is an issue we need to focus on fixing right now. It's a super edge case.

mallenexpensify commented 1 month ago

@RachCHopkins it happens with non-DM chats too, which makes me think we might want to fix.

image

@FitseTLT , what makes you think this should be BE? (honest question cuz I have no idea)

FitseTLT commented 1 month ago

lastMessage of the report is not updated correctly in the backend after editing the last message. It should be fixed in BE.

mallenexpensify commented 1 month ago

Thanks @FitseTLT

melvin-bot[bot] commented 1 month ago

@RachCHopkins this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 4 weeks ago

@RachCHopkins Huh... This is 4 days overdue. Who can take care of this?

mallenexpensify commented 4 weeks ago

@RachCHopkins I made it Internal, Weekly and added it to #vip-vsb, since the bug doesn't affect expensese

RachCHopkins commented 2 weeks ago

vip-vsb is on hold

RachCHopkins commented 1 week ago

Waiting for someone to pick this up