Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.31k stars 2.74k forks source link

RBR displayed in LHN in Most recent mode #46416

Closed m-natarajan closed 1 week ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dubielzyk-expensify Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721709354021959

Action Performed:

  1. Launch the app
  2. Observe LHN

    Expected Result:

    LHN status same in both preference mode

    Actual Result:

    RBR status in Most recent mode and no RBR in focus mode

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Native
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Native
    • [ ] iOS: mWeb Safari
    • [ ] MacOS: Chrome / Safari
    • [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

CleanShot 2024-07-23 at 14 34 52@2x

CleanShot 2024-07-23 at 14 34 02@2x

CleanShot 2024-07-23 at 14 36 42@2x

onyx-state (1).txt

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 1 month ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

rezkiy37 commented 1 month ago

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

rezkiy37 commented 1 month ago

I've tested it on my account. Looks like I have the inverted bug. RBR is not displayed, but there is a report with an error. Continue investigation.

https://github.com/user-attachments/assets/e493963b-66ec-4f92-b7e8-65dd90dc7311

rezkiy37 commented 1 month ago

I've fixed a case when the Inbox and Workspace list detect RBR for one transaction thread report. Opened a draft PR (https://github.com/Expensify/App/pull/46575). Continue investigation.

https://github.com/user-attachments/assets/7bf87c22-c601-47fa-991c-4ab3af6860de

rezkiy37 commented 1 month ago

Preparing the draft PR.

rezkiy37 commented 1 month ago

I've opened the PR (https://github.com/Expensify/App/pull/46575) for review. Also, I am still working on reproducing the initial bug.

trjExpensify commented 3 weeks ago

What's the latest here, are we ready to close this out after the regression period for https://github.com/Expensify/App/pull/46575?

dubielzyk-expensify commented 3 weeks ago

Just FYI that I still have this bug

rezkiy37 commented 3 weeks ago

I am continuing the investigation.

rezkiy37 commented 3 weeks ago

Other tasks occupied me, I will post updates next week.

rezkiy37 commented 2 weeks ago

Actively working on the issue.
@dubielzyk-expensify, can you please generate a new Onyx state file, because the old one is deprecated for the current app version? By the way, please check which kind of RBR you have for reports in the most recent mode. Is it a transaction either DM or workspace chat?

rezkiy37 commented 2 weeks ago

I've found missed RBRs during testing on a high-traffic account (eduardo.graciano+newdotperf@callstack.com).

Details

Screenshot 2024-08-19 at 14 52 03 Screenshot 2024-08-19 at 14 52 40

dubielzyk-expensify commented 2 weeks ago

The error was here for ages, but it seems like it's now gone away :( Still want me to generate Onyx?

rezkiy37 commented 2 weeks ago

@dubielzyk-expensify if it has gone away so let's close the issue. The bug was fixed.

dubielzyk-expensify commented 2 weeks ago

Yeah sounds good to me. I'll let y'all know if it reappears

rezkiy37 commented 2 weeks ago

Certainly!

rezkiy37 commented 2 weeks ago

@m-natarajan, please close the issue.

trjExpensify commented 1 week ago

Closing!