[$250] Log in - Shortcut modal doesn't open after logout

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Signout if you are logged in
2. Refresh the page
3. Press CMD+j (MacOS) to open shortcut modal

Expected Result:

Shortcut modal opens

Actual Result:

Shortcut modal doesn't opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/ec7bda4b-07f6-4889-b7e5-5cc3c063587b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a68d890586fd897d
• Upwork Job ID: 1818064897776942918
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot[bot]]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Log in - Shortcut modal doesn't open after logout

What is the root cause of that problem?

We are subscribing to the shortcut modal in AuthScreen https://github.com/Expensify/App/blob/3722b22302e5d89f2916d5e8958b2cf17ecb6285/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L280-L295 but the AuthScreen is rendered if the user is already authenticated

What changes do you think we should make in order to solve the problem?

We should take the subscription up in to a more general component like AppNavigator or Expensify or App And add the screen to the public screens navigator We can also check for other shortcuts which can be shown without authentication and do the same.

What alternative solutions did you explore? (Optional)

[jliexpensify]

I can repro

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01a68d890586fd897d

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[jayeshmangwani]

@jliexpensify Do we really need to show the shortcut page on the sign-in screen? We intentionally added all shortcut modals to the AuthScreen, as every shortcut will work after sign-in

[jliexpensify]

Ah, thanks for that context! In that case, we can close this one.