Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.88k forks source link

[$250] Web - Chat - Many emojis broken in emoji picker and chat history #46454

Open lanitochka17 opened 3 months ago

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.14-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4788750 Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify
  2. Navigate to a conversation
  3. Open the emoji picker
  4. Scroll down the list verifying each emoji is rendered correctly
  5. Select any of the broken emojis and send it.
  6. Enter broken emoji code in compose box, e.g. :troll:

Expected Result:

All emojis in emoji picker, chat history and suggestion list should be correctly rendered

Actual Result:

Many emojis are broken in emoji picker, chat history, suggestions and their tooltips are blank Example emoji codes: :troll:, :grey_heart:, :pregnant_person: Issue is probably Windows only

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/ea5e399c-3e0a-4bfa-97c5-59744e79bb1e

137!obraz

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019dcbe6141bd82081
  • Upwork Job ID: 1823783189793369593
  • Last Price Increase: 2024-08-14
  • Automatic offers:
    • mkhutornyi | Contributor | 103605686
Issue OwnerCurrent Issue Owner: @paultsimura
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 3 months ago

We think that this bug might be related to #vip-vsp

melvin-bot[bot] commented 3 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

chiragsalian commented 3 months ago

Not related to web-e repo. Clearing deployblocker label.

chiragsalian commented 3 months ago

Not sure if this is blocker worthy. I cannot reproduce it. image

image

image

Maybe the issue is only on windows as mentioned in the title. @stitesExpensify do you have any insight about this issue? if not i was going to mark it as external.

chiragsalian commented 3 months ago

Oh whoops i missed that it was already discussed here. Looks like we might be reverting the offending PR.

mkhutornyi commented 3 months ago

https://github.com/Expensify/App/pull/43815 is the culprit

mananjadhav commented 3 months ago

I can't reproduce this. These are new Emojis that we added, but I am not sure what's the best way to address this when it could be browser version specific. I am not sure if this should be a Deploy blocker.

image image
chiragsalian commented 3 months ago

i cannot reproduce issue on windows machine, i've asked QA to retest here.

chiragsalian commented 3 months ago

Demoting since we're unable to reproduce.

MelvinBot commented 3 months ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

m-natarajan commented 3 months ago

Tester is still able to reproduce the issue.

https://github.com/user-attachments/assets/bea078a5-9c01-48d1-8809-a134a7c7f4bc

https://github.com/user-attachments/assets/2579acbc-d322-4675-92ca-889052fb85ab

mananjadhav commented 3 months ago

Can we get some more information on the system, OS , browser etc. version?

m-natarajan commented 3 months ago

Desktop: Windows 10 Pro/ Chrome Version 127.0.6533.89 (Official Build) (64-bit) iOS: iPhone 7/iOS 15.8.2

Build - v9.0.14-5

mkhutornyi commented 3 months ago

I also reproduced on my windows

https://github.com/user-attachments/assets/563a3219-9ccd-4385-96cc-df5347ab3256

chiragsalian commented 2 months ago

Okay marking it as external. For anyone that can reproduce let us know if you are able to figure out and solve the issue. We can ask QA to test on your PR to see if the issue is resolved.

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~019dcbe6141bd82081

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

paultsimura commented 2 months ago

I could not reproduce it either. @mkhutornyi since you could – would you like to take over as C+ here?

mkhutornyi commented 2 months ago

Still reproduced on latest staging v9.0.21-3

I could not reproduce it either. @mkhutornyi since you could – would you like to take over as C+ here?

sure

paultsimura commented 2 months ago

Cool. @chiragsalian please re-assign to @mkhutornyi 🙏

melvin-bot[bot] commented 2 months ago

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

mkhutornyi commented 2 months ago

Waiting for proposals

melvin-bot[bot] commented 2 months ago

@chiragsalian, @mkhutornyi Huh... This is 4 days overdue. Who can take care of this?

chiragsalian commented 2 months ago

Waiting for proposals. Demoting to weekly.

chiragsalian commented 1 month ago

Still waiting for proposals. Demoting to monthly because its only affecting windows users.

chiragsalian commented 2 weeks ago

Still waiting for proposals.

mkhutornyi commented 1 week ago

I will be OOO from tomorrow so please reassign if C+ review is needed. Status: no proposals yet