[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-09] [HOLD for payment 2024-08-07] Expense - "Business bank account" option appears briefly when paying with Expensify

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-2 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace does not have bank account.

1. Launch New Expensify app.
2. Go to workspace chat.
3. Submit an expense.
4. Tap Pay with Expensify.

Expected Result:

"Business bank account" option will not appear briefly when paying with Expensify

Actual Result:

"Business bank account" option appears briefly when paying with Expensify

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/d26c1705-9999-498e-99b0-fb4cc0b2072b

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[gijoe0295]

Regression from https://github.com/Expensify/App/pull/46323. I explained it here cc @marcaaron

[trjExpensify]

@marcaaron if you're okay with that, can we get a fix up here?

[marcaaron]

Yeah if someone wants to raise a PR I can help review and merge.

[marcaaron]

@gijoe0295 let's fix this as part of https://github.com/Expensify/App/issues/46339 - I will help CP the fix when it's ready.

[gijoe0295]

PR ready in 3 hours.

[mountiny]

@gijoe0295 what is your updated ETA?

[gijoe0295]

@mountiny Oops. PR is ready https://github.com/Expensify/App/pull/46557. I forgot to link this issue.

[roryabraham]

We're CPing a fix for the blocker, but it's not clear to me if there's any other cleanup still needed

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.14-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46598

If no regressions arise, payment will be issued on 2024-08-07. :confetti_ball:

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@marcaaron] Determine if we should create a regression test for this bug.
• [ ] [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

We're CPing a fix for the blocker, but it's not clear to me if there's any other cleanup still needed

Nah, we can use the other issue for @gijoe0295's PR for the workspace chat redirect fix: https://github.com/Expensify/App/pull/46557

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.15-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46598

If no regressions arise, payment will be issued on 2024-08-09. :confetti_ball:

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@marcaaron] Determine if we should create a regression test for this bug.
• [ ] [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46557

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball:

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@marcaaron] Determine if we should create a regression test for this bug.
• [ ] [@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[trjExpensify]

Going to take care of payment for this one here: https://github.com/Expensify/App/issues/46339#issuecomment-2291034991