search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Performance] After clicking on a search result it took 4x OpenReport requests to open the final report #46594

Open hannojg opened 1 month ago

hannojg commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

What performance issue do we need to solve?

A customer was searching for a chat, clicking on it, and then it took a long loading time and actually 4x OpenReport queries for the final chat to open:

https://github.com/user-attachments/assets/53bd9d0b-13ca-477e-908f-7b99cd346a2e

What is the impact of this on end-users?

TTI with the chat

List any benchmarks that show the severity of the issue

I have a copy of all network requests available. As they contain customer data I can't post them here. If you're working on that issue please let me know

The customer also shared a profile trace with us:

Firefox 2024-07-25 10.42 profile.json.gz

(note: the trace also contains other test cases as well)

Proposed solution (if any)

None yet, I will go through the profile and see what can be optimised, what exactly caused those lags.

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

not available yet

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v9.0.11-5 Reproducible in staging?: not tested Reproducible in production?: yes Email or phone of affected tester (no customers): customer Logs: See performance file Notes/Photos/Videos: See attached video Expensify/Expensify Issue URL: n/a Issue reported by: @hannojg Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721919928992729

View all open jobs on Upwork

melvin-bot[bot] commented 1 month ago

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

hannojg commented 1 month ago

cc @sakluger (feel free to assign me as I (or someone from my team) will work on this ticket!)

sakluger commented 1 month ago

No updates

sakluger commented 1 month ago

No update

sakluger commented 1 month ago

No update

sakluger commented 1 month ago

@hannojg should we leave this as a daily, or will it be a week or more before you can prioritize this one?

sakluger commented 1 month ago

Moving to weekly for now since Hanno is out until Monday.

sakluger commented 4 weeks ago

@hannojg any updates on this one?

hannojg commented 4 weeks ago

This is a rather tricky bug as reproducing it is hard. We have this currently as low priority to address overall performance issues first!

sakluger commented 2 weeks ago

I asked for updates in the main tracking issue: https://github.com/Expensify/App/issues/46595

sakluger commented 2 weeks ago

We're focusing on the slow search first. We have a WIP PR for that, I assume we'll look at this again once that is done.

sakluger commented 6 days ago

No update