search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

Taxes - Tax code content is not shown until the workspace is upgraded to Control #46624

Closed m-natarajan closed 1 month ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating https://github.com/Expensify/App/pull/45866 Version Number: 9.0.15-4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a Collect workspace.
  3. Go to workspace settings > Taxes.
  4. Click on any tax.
  5. Note that Tax code is empty.
  6. Click on the Tax code.
  7. Click Upgrade.
  8. Note that Tax code content is only shown after upgrading to Control.

Expected Result:

in Step 5, Tax code content will be shown even if the workspace plan is Collect (production behavior).

Actual Result:

in Step 5, Tax code content is not shown until the workspace is upgraded to Control (Step 8).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/1b9cd591-40ee-4771-ac56-dd8909d4a114

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

m-natarajan commented 1 month ago

We think that this bug might be related to #wave-control

neonbhai commented 1 month ago

This should be expected as noted in https://github.com/Expensify/App/pull/45866#issuecomment-2243358998

we are going to hide the taxID for non control policy because it makes it look more like its behind a paywall

cc: @rushatgabhane

rushatgabhane commented 1 month ago

this is not a bug. it is expected

rushatgabhane commented 1 month ago

thanks for tagging @neonbhai

brunovjk commented 1 month ago

Should we create a regre test here including this scenario?

melvin-bot[bot] commented 1 month ago

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

strepanier03 commented 1 month ago

@brunovjk - I agree we should create the reg test for this. Gonna close out this GH but feel free to comment in that other one.