Open m-natarajan opened 1 month ago
Triggered auto assignment to @VictoriaExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Only admin is displayed in member list but the member count is displayed as 2
We do not filter out the accountID that is not available in personalDetails data: https://github.com/Expensify/App/blob/157afbf7720049e3b0a92836b440c35f17725c10/src/pages/ReportDetailsPage.tsx#L146-L149 like we did in https://github.com/Expensify/App/blob/157afbf7720049e3b0a92836b440c35f17725c10/src/pages/ReportParticipantsPage.tsx#L71-L73
We should check if the accountID is available in personalDetails data or not. If not, remove from activeChatMembers
https://github.com/Expensify/App/blob/157afbf7720049e3b0a92836b440c35f17725c10/src/pages/ReportDetailsPage.tsx#L146-L149
We also can filter out in https://github.com/Expensify/App/blob/157afbf7720049e3b0a92836b440c35f17725c10/src/pages/ReportDetailsPage.tsx#L139-L142
true
true
Recreated issue:
Agree we should fix this.
Job added to Upwork: https://www.upwork.com/jobs/~0158f19a1453ec7c77
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External
)
@dominictb's proposal has the correct RCA and the proposed solution looks good to me. Let's go with them.
π π π C+ reviewed
Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @dominictb π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
This issue has not been updated in over 15 days. @Gonals, @allroundexperts, @VictoriaExpensify, @dominictb eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Payment summary: Contributor: @dominictb paid $250 via Upwork
@allroundexperts I will make your payment once the checklist is complet
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.15-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722451867724679
Action Performed:
Expected Result:
Both admin and chat specialist displayed in admin room
Actual Result:
Only admin is displayed in member list but the member count is displayed as 2
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/09687bb4-da2b-4c0b-a8ea-14f7f7870c05
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexperts