search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-08-19] [Fullstory] Initializing the Onyx object to identify the user when they have an infinite session on New Dot #46677

Closed anmurali closed 2 months ago

anmurali commented 3 months ago

Problem: Initializing the Onyx object on SignInWithShortLivedAuthToken will make it so a user on Classic with an infinite session, on redirect to New Dot will now be identified in FS. But if they were already on New Dot, and had an infinite session, we will not identify them till they explicitly login next.

Solution: Initialize this object on OpenApp/Reopen App as well.

Note: While we do this, can we also make it so the Onyx object includes the tryNewDot.classicRedirect.dismissed If that is true - send true, if false then send false If that NVP does not exist, send empty

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.18-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. :confetti_ball:

danieldoglas commented 2 months ago

This is done, there's no payment to be made