search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

[$250] Sign in – Chat long loading when login via magic link using Recovery code #46730

Closed lanitochka17 closed 1 week ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.16-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4804201 Email or phone of affected tester (no customers): ponikarchuks+102824@gmail.com Issue reported by: Applause - internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. In Sign in page enter Gmail email of a user with 2FA enabled
  3. Open email and navigate via Magic link
  4. Go back to Sign in page and click Use recovery code
  5. Paste Recovery code and press Sign in

Expected Result:

Chat history opens

Actual Result:

Chat long loading

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/da60b43c-ea0d-49f8-8f2f-6a34638d5223

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013259ceff7cd5e594
  • Upwork Job ID: 1820564666420399442
  • Last Price Increase: 2024-09-02
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 1 month ago

We think that this bug might be related to #vip-vsp

melvin-bot[bot] commented 1 month ago

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~013259ceff7cd5e594

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

melvin-bot[bot] commented 1 month ago

@johncschuster, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster commented 1 month ago

@jjcoffee, it's very likely this issue will be closed if we can't either 1) have it fixed by an external contributor, or 2) redistribute this under a different, prioritized project.

vip-vsb has been deprioritized internally, so if this winds up being a BE issue, we will likely close it.

jjcoffee commented 1 month ago

Hmm I can't repro myself, @lanitochka17 can you retest and let us know if there are any specific extra steps involved? There's a cut in the video so I'm wondering if there's something missing from there.

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

johncschuster commented 3 weeks ago

Asking in Slack for a restest

lanitochka17 commented 3 weeks ago

Chat long loading, but opens

https://github.com/user-attachments/assets/9b87c3f6-3a2b-46b2-87bf-8a8d50ba247c

jjcoffee commented 3 weeks ago

@lanitochka17 Thanks for the retest! Can you confirm if this only happens when you have two tabs open?

melvin-bot[bot] commented 3 weeks ago

@johncschuster @jjcoffee this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

jjcoffee commented 3 weeks ago

Not overdue, waiting for @lanitochka17's response on the above.

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

lanitochka17 commented 3 weeks ago

The problem reproducible when logging in via the Magic link on the second tab, i.e. two tabs open.

johncschuster commented 3 weeks ago

@jjcoffee looks like we've got our confirmation on the repro steps!

jjcoffee commented 3 weeks ago

Trying to get some attention on this on Slack.

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

johncschuster commented 2 weeks ago

Bumped in Slack!

NJ-2020 commented 2 weeks ago

I cannot reproduce this issue

jjcoffee commented 2 weeks ago

@NJ-2020 Thanks for trying! Did you make sure to open the magic link in a new tab?

NJ-2020 commented 2 weeks ago

@jjcoffee Yes but i couldn't reproduce the issue

johncschuster commented 1 week ago

Asking for a restest

melvin-bot[bot] commented 1 week ago

@johncschuster @jjcoffee this issue is now 4 weeks old, please consider:

Thanks!

m-natarajan commented 1 week ago

Works good now

https://github.com/user-attachments/assets/cb90698e-cd50-4388-9e9c-758c3b1cca68

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 week ago

@johncschuster, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

johncschuster commented 1 week ago

Just saw the results from this comment. Looks like we can button this one up!