Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

Invoice - Improve the email when an invoice is sent over NewDot #46731

Open izarutskaya opened 1 month ago

izarutskaya commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.16-0 Reproducible in staging?: Y Reproducible in production?: Unable to check Found when validating PR : https://github.com/Expensify/Web-Expensify/pull/42161 Email or phone of affected tester (no customers): shussain+chrome1@applausemail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Login in NewDot with a workspace admin account and open the Global Create
  2. Send an invoice to someone who hasn't received an email from this workspace before. Do not sign in with the invoice recipient account (we don't want them to mark the report actions from the invoice room as read)
  3. Verify that they get an email with the invoice
  4. Reply to this message or respond at new.expensify.com
  5. Send some messages to the invoice room
  6. Send a new invoice to the same recipient or to the invoice room
  7. Verify that the recipient gets an email with the messages sent to the room and an email with the new invoice.

Expected Result:

Actual Result:

No user email in the received email and also no intro in the first invoice email.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/16a611d3-1df5-4e81-878f-f704267505b7

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 1 month ago

We think this issue might be related to the #collect project.

neonbhai commented 1 month ago

These emails are sent from BE, we'll need the Internal label here

Beamanator commented 1 month ago

99% sure this is from https://github.com/Expensify/Web-Expensify/pull/42161 - cc @cristipaval

srikarparsi commented 1 month ago

Hey @cristipaval! Would you be able to take this one over?

cristipaval commented 1 month ago

Not a blocker

cristipaval commented 1 month ago

@davidcardoza, could you please help prioritize this?

cristipaval commented 1 month ago

@davidcardoza I'm stepping back given that I'm getting close to my parental leave and I have many other issues on my plate. I applied hot-picks label on it

melvin-bot[bot] commented 3 weeks ago

this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 6 days ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!