[$250] Expense - Pay with Expensify button appears for Employee after admin disconnects bank account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Delayed submission is enabled in Workflows
• Workspace has an approver (admin)
• Workspace has set up with bank account
• Employee does not have bank account
  1. Go to staging.new.expensify.com
  2. [Employee] Go to workspace chat
  3. [Employee] Submit an expense over $100
  4. [Employee] Click on the submit button and stay on the main chat
  5. [Admin] Click Approve button on the expense preview
  6. [Admin] Go to workspace settings > Workflows
  7. [Admin] Click on the bank account
  8. [Admin] Disconnect bank account
  9. [Employee] Note that "Pay with Expensify" button shows up on expense preview on employee end after admin has disconnected bank account

Expected Result:

"Pay with Expensify" button will not appear on expense preview on employee end after admin has disconnected bank account

Actual Result:

"Pay with Expensify" button shows up on expense preview on employee end after admin has disconnected bank account. When clicking on the expense preview and returning to main chat, the button disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/ee48cf85-86b5-410f-a14d-a12c851cc1b4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e26750961886bca4
• Upwork Job ID: 1821153286159845456
• Last Price Increase: 2024-08-28
• Automatic offers:
• jjcoffee | Reviewer | 103796028

Issue Owner

Current Issue Owner: @teneeto

[melvin-bot[bot]]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot[bot]]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e26750961886bca4

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot[bot]]

@jjcoffee, @miljakljajic Huh... This is 4 days overdue. Who can take care of this?

[jjcoffee]

Waiting for proposals!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jjcoffee]

Bumped on Slack to hopefully get some proposals in!

[melvin-bot[bot]]

@jjcoffee @miljakljajic this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[jjcoffee]

@miljakljajic Maybe we should try bumping the price to get more eyes on this?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jjcoffee]

This isn't getting any attention, let's bump the price @miljakljajic

[melvin-bot[bot]]

@jjcoffee, @miljakljajic Huh... This is 4 days overdue. Who can take care of this?

[miljakljajic]

reconfirming the expected outcome here - I'm not clear on why the employee would see the Pay with Expensify option

[jjcoffee]

@miljakljajic I think the issue is that Pay with Expensify should not appear for the employee at all, but it does appear once the admin disconnects the bank account. @lanitochka17 can you confirm?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@jjcoffee @miljakljajic this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

@jjcoffee, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[jjcoffee]

@miljakljajic Should we bump the price to get more eyes on this?

[teneeto]

Hey! I'm Eto Olei from Callstack. I will like to look into this issue. Please assign it to me. Thanks!

[miljakljajic]

Thank you @teneeto! I will

[melvin-bot[bot]]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[teneeto]

Hi @miljakljajic, FYI I have an unexpected review that needs my attention. Will come back to this in no time.

[melvin-bot[bot]]

@teneeto, @jjcoffee, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jjcoffee]

Not overdue - just waiting for @teneeto to pick this back up.

[teneeto]

Hi @miljakljajic, I'm back to looking into this.

[miljakljajic]

Thank you!

[melvin-bot[bot]]

@teneeto, @jjcoffee, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jjcoffee]

Just waiting for @teneeto! :pray:

[teneeto]

Hey hey! I'm still investigating and have to dig in a little.

[melvin-bot[bot]]

@teneeto, @jjcoffee, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[teneeto]

Hya, I' still on this and just a tiny bit more to check and I'll post findings.

[jjcoffee]

Sweet, thanks for the update!

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[miljakljajic]

Assigning this over to another BZ member as I'm heading out on parental leave.

@twisterdotcom - we are waiting for an update from @teneeto at Call stack before moving forward. Thank you!

[teneeto]

O yea, still checking and will share updates by EOD.

[melvin-bot[bot]]

@twisterdotcom, @teneeto, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twisterdotcom]

Any updates @teneeto?

[teneeto]

@twisterdotcom, I suspect this to be BE - all checks on FE passes so far. I'm just looking at one more thing. I'm not done. Once I can be sure I can share my thoughts, My apologies for not posting updates as promised earlier. Thanks.

[teneeto]

I managed to track the issue all the way down to this condition here: https://github.com/teneeto/Expensify/blob/dcf1a0cac762ef658ebfa8f692331f04828d6716/src/libs/ReportUtils.ts#L1640-L1649

Each time a workspace bank account is removed, !policy?.achAccount?.reimburser is opimistically updated which sets that condition to true and then causing the settlement button to show. This shouldn't even be a problem. The main issue there is, the conditions there don't fall through as it should at least for this operation.

I'm still looking at how best this could be fixed - which i don't expect, should take any longer before i raise a PR.

[melvin-bot[bot]]

@twisterdotcom, @teneeto, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

[teneeto]

@twisterdotcom @jjcoffee a PR is raised here: https://github.com/Expensify/App/pull/49969

Here are my thoughts on my solution and possible alternatives (if needed).

Problem

On these lines: https://github.com/teneeto/Expensify/blob/dcf1a0cac762ef658ebfa8f692331f04828d6716/src/libs/ReportUtils.ts#L1641 and https://github.com/teneeto/Expensify/blob/dcf1a0cac762ef658ebfa8f692331f04828d6716/src/libs/ReportUtils.ts#L1645, we are doing condition to check for payer and depending on whether or not a bank account is connected, those conditions are triggered. The issue is when a bank account is disconnected, the second condition is not immediately triggered because policy?.reimbursementChoice is not immediately or optimistically updated when the bank account is disconnected - except you force a page reload or the endpoint is re-triggered.

Soution

I found another field policy?.reimbursement?.choice?.reimbursementChoice which updates as expected. policy?.reimbursementChoice is now used as a fallback. const reimbursementChoice = policy?.reimbursement?.choice?.reimbursementChoice ?? policy?.reimbursementChoice;

alternate solution

We can find out why policy?.reimbursementChoice doesn't optimistically update, fix it and then use it again.

Screenshot

The video below shows a log of policy objects and the variation in the reimbursement choice fields after the bank account is disconnected.

---

https://github.com/user-attachments/assets/b05a9257-143d-4ebd-bb4c-149be7526b78

[jjcoffee]

@teneeto Thanks for the investigation and for the detailed write-up! I just need to clarify a few points before proceeding.

when a bank account is disconnected, the second condition is not immediately triggered

Are you saying that once the bank account is disconnected, the reimbursementChoice should be CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL?

I think the main confusion for me here is that the employee shouldn't be seeing the pay button at all as they are not the "reimburser" (in either condition). So it seems like once the bank account is disconnected, the employee is treated as the reimburser for some reason.

https://github.com/Expensify/App/blob/dcf1a0cac762ef658ebfa8f692331f04828d6716/src/libs/ReportUtils.ts#L1641-L1647

[teneeto]

Yes, reimbursementChoice should be CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL. For the second point, I can't say I'm 100% sure of what the flow should be but yes, that contributed to the issue as well, I also stated it here: https://github.com/Expensify/App/issues/46738#issuecomment-2378746230. Either way, it involves the values being updated from BE.

Overall, the conditions with reimbursementChoice are the parent issue. If that is solved properly then it handles the confusing part as well.

[jjcoffee]

That makes sense, thanks! I guess policy?.achAccount?.reimburser is getting removed along with the bank account which is another part of the issue.

I'm a bit unsure on why there are two fields for reimbursementChoice that you mention in your solution, so I'm gonna get an engineer assigned to make sure it's okay to switch to.

:ribbon::eyes::ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

The RCA here makes sense to me. I do think we should go with the alternate solution listed though since we already store reimbursementChoice and don't think we need a new variable for that data.

Also, I don't think we should ever show the pay button to regular employees (not admins, managers...). @rlinoz, do you know why we show the settlement button in this line if reimburser is empty (and the report is approved)?

[rlinoz]

I think it comes from here actually https://github.com/Expensify/App/pull/38253, but I am not sure what we were fixing, maybe @luacmartins remembers