Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$250] Expense - Pay with Expensify button appears for Employee after admin disconnects bank account #46738

Open lanitochka17 opened 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.16-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Expected Result:

"Pay with Expensify" button will not appear on expense preview on employee end after admin has disconnected bank account

Actual Result:

"Pay with Expensify" button shows up on expense preview on employee end after admin has disconnected bank account. When clicking on the expense preview and returning to main chat, the button disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/ee48cf85-86b5-410f-a14d-a12c851cc1b4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e26750961886bca4
  • Upwork Job ID: 1821153286159845456
  • Last Price Increase: 2024-08-28
  • Automatic offers:
    • jjcoffee | Reviewer | 103796028
Issue OwnerCurrent Issue Owner: @jjcoffee
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 1 month ago

We think that this bug might be related to #wave-collect - Release 1

melvin-bot[bot] commented 1 month ago

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~01e26750961886bca4

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

melvin-bot[bot] commented 1 month ago

@jjcoffee, @miljakljajic Huh... This is 4 days overdue. Who can take care of this?

jjcoffee commented 1 month ago

Waiting for proposals!

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

jjcoffee commented 1 month ago

Bumped on Slack to hopefully get some proposals in!

melvin-bot[bot] commented 1 month ago

@jjcoffee @miljakljajic this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

jjcoffee commented 4 weeks ago

@miljakljajic Maybe we should try bumping the price to get more eyes on this?

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

jjcoffee commented 3 weeks ago

This isn't getting any attention, let's bump the price @miljakljajic

melvin-bot[bot] commented 2 weeks ago

@jjcoffee, @miljakljajic Huh... This is 4 days overdue. Who can take care of this?

miljakljajic commented 2 weeks ago

reconfirming the expected outcome here - I'm not clear on why the employee would see the Pay with Expensify option

jjcoffee commented 2 weeks ago

@miljakljajic I think the issue is that Pay with Expensify should not appear for the employee at all, but it does appear once the admin disconnects the bank account. @lanitochka17 can you confirm?

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 2 weeks ago

@jjcoffee @miljakljajic this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 1 week ago

@jjcoffee, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

jjcoffee commented 1 week ago

@miljakljajic Should we bump the price to get more eyes on this?

teneeto commented 1 week ago

Hey! I'm Eto Olei from Callstack. I will like to look into this issue. Please assign it to me. Thanks!

miljakljajic commented 1 week ago

Thank you @teneeto! I will

melvin-bot[bot] commented 1 week ago

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

teneeto commented 1 week ago

Hi @miljakljajic, FYI I have an unexpected review that needs my attention. Will come back to this in no time.

melvin-bot[bot] commented 1 week ago

@teneeto, @jjcoffee, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

jjcoffee commented 1 week ago

Not overdue - just waiting for @teneeto to pick this back up.

teneeto commented 5 days ago

Hi @miljakljajic, I'm back to looking into this.

miljakljajic commented 3 days ago

Thank you!

melvin-bot[bot] commented 3 days ago

@teneeto, @jjcoffee, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

jjcoffee commented 3 days ago

Just waiting for @teneeto! :pray:

teneeto commented 3 days ago

Hey hey! I'm still investigating and have to dig in a little.