[HOLD for payment 2024-08-14] [HOLD for payment 2024-08-13] iOS - Distance - Unable to delete waypoint from 3-dot menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to workspace chat
3. Submit a distance expense with three waypoints
4. Go to transaction thread
5. Tap Distance
6. Tap on waypoint
7. Tap on the three-dot menu
8. Tap Delete waypoint

Expected Result:

App will show confirmation prompt to delete the waypoint

Actual Result:

Nothing happens after tapping Delete waypoint from 3-dot menu User is unable to delete waypoint from 3-dot menu option

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/775b2a57-6cbd-4002-9cba-ac342f62e8f7

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[aldo-expensify]

Investigating this now...

[aldo-expensify]

Can't reproduce in Web:

https://github.com/user-attachments/assets/8d520375-e15f-4969-9434-b36e72d15314

so maybe it really happens only in IOS native... going to test in the IOS emulator

[aldo-expensify]

just managed to have my IOS emulator working, I'll keep testing after lunch

[aldo-expensify]

Reproduced in dev + emulator

[aldo-expensify]

So far I see that isDeleteStopModalOpen is set to true correctly when I click Delete waypoint in the menu that appears from below. I'm looking into why the modal doesn't appear after.

https://github.com/Expensify/App/blob/df46bcd978906a54301d5fdc0a03ac4402ea5459/src/pages/iou/request/step/IOURequestStepWaypoint.tsx#L61

[roryabraham]

Might I suggest retrying this offline? If reproducible offline I think we can remove the DeployBlocker label (not to be confused with DeployBlockerCash)

[aldo-expensify]

I'll check, I didn't notice the DeployBlocker, I highly doubt this is backend related... just a sec

[aldo-expensify]

Reproduced while offline

[aldo-expensify]

I verified that this is not happening in the production branch, so I think it is a real DeployBlockerCash. I'll see if comparing the branches can give me a better idea of what went wrong.

[aldo-expensify]

I think the bug is coming from this PR: https://github.com/Expensify/App/pull/45762 If I revert the changes in PopoverMenu the bug goes away

[aldo-expensify]

oh, maybe we need to do something similar to this:

[aldo-expensify]

PR up: https://github.com/Expensify/App/pull/46755

[zfurtak]

@aldo-expensify hello 😊 In my PR I changed a bit the structure of PopoverMenu as it was causing a different bug. I checked all of the usages but apparently missed this one. Your PR is exactly how I would fix it!

[roryabraham]

looks like this was fixed without external contribution. Closing this out

[marcaaron]

Sorry I think that there is still some problem here can someone please look at this it's blocking the deploy and I'm not able to figure it out, thanks!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.16-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46755

If no regressions arise, payment will be issued on 2024-08-13. :confetti_ball:

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46755

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball: