search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

[$1000] Implement new Google Places API #46771

Open rafecolton opened 4 months ago

rafecolton commented 4 months ago

Coming from https://github.com/Expensify/App/issues/45432, please implement the new Places API as described in this comment.

We'll follow the usual process of starting with a detailed proposal, but I will assign @rojiphil directly as the Contributor here since he has the most context.

I will be the CME and will also help with getting the API key updated/installed.

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015599eafb1cb0d217
  • Upwork Job ID: 1819786402974465675
  • Last Price Increase: 2024-08-03
  • Automatic offers:
    • mkhutornyi | Reviewer | 103384006
    • rojiphil | Contributor | 103384007
Issue OwnerCurrent Issue Owner: @rafecolton
rafecolton commented 2 months ago

Marking Reviewing as all related PRs are under review currently

Christinadobrzyn commented 2 months ago

With Reviewing, should we move this from daily to weekly?

rafecolton commented 2 months ago

Let's keep it at Daily. In fact, I'll take it out of reviewing and make @rojiphil the issue owner until the final App PR is ready to review.

rafecolton commented 1 month ago

Final PR is now up for review! Cool to see that Melvin added the labels automagically ✨

rafecolton commented 1 month ago

PR is failing on android without content-type header, but with the header, it produces a CORS error. I dug into that before when I was testing and it was a rabbit hole, but since it seems to be required here, I'll have to dig more. Setting myself as the issue owner now since this is blocked on me. Might not be able to get back to this until next week, have some higher priority issues assigned currently

rafecolton commented 1 month ago

Thanks for your patience on this @rojiphil - I still plan on getting back to this as soon as I wrap up some other issues

melvin-bot[bot] commented 1 week ago

This issue has not been updated in over 15 days. @rafecolton, @rojiphil, @Christinadobrzyn, @mkhutornyi eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

rafecolton commented 1 week ago

Sorry to leave this sit for so long. It's still on my radar, just not able to prioritize at the moment.