Closed m-natarajan closed 1 month ago
Triggered auto assignment to @OfstadC (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Job added to Upwork: https://www.upwork.com/jobs/~01b480770995fdef2d
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External
)
Tag no longer valid violation appears on optional multilevel tag after changing a required tag
The multi-level tag has the format A:B:C
, when we only select C, the tag is stored in the transaction as ::C
Then the selectedTags
here is ['', '', 'C']
https://github.com/Expensify/App/blob/0ee0fe34c5a3e0dae89fc88140025f0bc6d67276/src/libs/Violations/ViolationsUtils.ts#L84
That makes isTagInPolicy
is false
for the first selected tag then the violation is added and shown in the money request view
https://github.com/Expensify/App/blob/0ee0fe34c5a3e0dae89fc88140025f0bc6d67276/src/libs/Violations/ViolationsUtils.ts#L115
If the selectedTag
tag here is empty, we shouldn't add the violation since we passed the required tag check below and it can be empty
if (!isTagInPolicy && selectedTag) {
@nkdengineer's proposal LGTM π -> All points mentioned in the RCA check-out and the proposed solution fixes the issue accordingly, fulfilling the Expected result of the issue.
πππΒ C+ reviewed
Current assignee @cead22 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
π£ @ikevin127 π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @nkdengineer π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.18-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Do we agree π or π.
We have a pretty comprehensive list of tests for violations now, which should cover this, righ @isagoico ?
cc @OfstadC
@ikevin127 paid $250 via Upwork @nkdengineer paid $250 via Upwork
Sounds like we don't need regression testing here - so I'll close. But if that changes, feel free to tag me and i'll create an issue π
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.15-6 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @cead22 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722618234255979
Action Performed:
Expected Result:
Violation shouldn't show
Actual Result:
Tag no longer valid
violation appears on optional multilevel tag after changing a required tagWorkaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/d9df1479-9b90-41a1-8c7c-2ac63ce62d8d
https://github.com/user-attachments/assets/7b66bae0-849f-41a2-a208-c4c4ab510539
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @OfstadC