search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline #46874

Closed lanitochka17 closed 2 months ago

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.17-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Go offline
  4. Submit a distance expense
  5. Go to transaction thread
  6. Click Distance
  7. Change the waypoints (by exchanging position)
  8. Save it

Expected Result:

App will not crash

Actual Result:

App crashes when submitting distance expense and editing distance offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/72863626-e2c6-489f-b0c5-69662a919261

logs (2).txt

View all open jobs on GitHub

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
BrtqKr commented 3 months ago

convertToDisplayString() seems to be receiving 'Pending...' as a currency, which probably happens after editing the expense offline. I can dig deeper into it if that's ok.

That's probably unrelated to this particular bug, but I'm also getting double workspaces after creating a new one 🤔

grgia commented 3 months ago

https://github.com/Expensify/App/pull/46165/ https://github.com/Expensify/App/pull/40021

could be related. It does seem like ^ is the issue

grgia commented 3 months ago

@BrtqKr maybe https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L255-L257

paultsimura commented 3 months ago

Ohh, this is a regression from my PR. Will spin up a fix now.

grgia commented 3 months ago

Assigning @paultsimura!

marcaaron commented 3 months ago

I think we're good to remove the blocker here based on @AndrewGable's message here.

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.18-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 months ago

Issue is ready for payment but no BZ is assigned. @stephanieelliott you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 2 months ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@stephanieelliott)

paultsimura commented 2 months ago

No payment here - it was a regression fix.