Open lanitochka17 opened 1 month ago
Triggered auto assignment to @kevinksullivan (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
Edited by proposal-police: This proposal was edited at 2024-08-06 14:29:58 UTC.
Rooms mention list does not appear in message edit mode
Because we passed isGroupPolicyReport
as false here
https://github.com/Expensify/App/blob/0e46257f3295243e5ef306b723288cb1673ed6f1/src/pages/home/report/ReportActionItemMessageEdit.tsx#L535-L536
We also didn't pass the policyID
to Suggestions
We need to pass isGroupPolicyReport and policyID in here https://github.com/Expensify/App/blob/0e46257f3295243e5ef306b723288cb1673ed6f1/src/pages/home/report/ReportActionItemMessageEdit.tsx#L535 by getting the value as we did here
const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID ?? '-1'}`);
isGroupPolicyReport={isGroupPolicyReport}
policyID={report?.policyID}
@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Job added to Upwork: https://www.upwork.com/jobs/~01dedb57180f356839
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External
)
@eVoloshchak, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!
@eVoloshchak, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@eVoloshchak, @kevinksullivan Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
@eVoloshchak @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@eVoloshchak can you review the proposal please?
Rooms mention list does not appear in message edit mode
The SuggestionMention component requires to have isGroupPolicyReport
and policyID
to render room mention list.
We are passing isGroupPolicyReport
as false and we are not passing policyID
The ReportActionItemMessageEdit
component is already receiving isGroupPolicyReport
we just need to propagate the prop.
And from that same component we already have access to the report policyID
, so it'll only need to pass that prop to ReportActionItemMessageEdit
and propagate the prop.
@FitseTLT's proposal looks good to me
πππ C+ reviewed!
Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @FitseTLT π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Looping in a BZ member to handle payment as I'm going OOO
Triggered auto assignment to @puneetlath (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@eVoloshchak when will this need paying?
@puneetlath, not clear yet, as this wasn't deployed to staging/prod yet Latest update:
This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.17-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4826336 Email or phone of affected tester (no customers): fischer9966@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
User can select room mention from suggestion list in edit mode
Actual Result:
Rooms mention list does not appear in message edit mode
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/65c1c3d9-b836-44a2-ab94-75f02228605f
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eVoloshchak