Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD #47136 ][$250][P2P Distance] Expense shared with accountant shows incorrect rate #46897

Open m-natarajan opened 1 month ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.17-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @paultsimura Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722892285723489

Action Performed:

  1. Open the chat with yourself
  2. Submit a Distance request
  3. In the Concierge prompt, click "Share it with my accountant"
  4. Select a workspace and a different rate
  5. Submit the request
  6. Navigate to the request details page

Expected Result:

Actual Result:

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/b161ebd9-eefb-46aa-97c7-f77a8fd373c5

https://github.com/user-attachments/assets/3f69d06a-b047-4f72-b5e4-1c99275ba94c

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019b051306a76e7ed6
  • Upwork Job ID: 1821591099314477155
  • Last Price Increase: 2024-08-22
Issue OwnerCurrent Issue Owner: @Pujan92
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~019b051306a76e7ed6

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

melvin-bot[bot] commented 1 month ago

@Pujan92, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

wildan-m commented 1 month ago

How can we enable the rate option for personal track expense? I think distance rate feature only available in workspace

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@Pujan92, @sonialiap Still overdue 6 days?! Let's take care of this!

sonialiap commented 1 month ago

@wildan-m I believe you're correct that you can't change the rate on a personal expense, but you don't need to do that. For this issue you want to have a workspace with multiple rates. Then, once you share the expense with someone on that workspace you will have the option to select one of the workspace rates

sonialiap commented 1 month ago

I'm OOO Aug 19-30, adding leave buddy

Status: Status: waiting for/ c+ reviewing proposals

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

paultsimura commented 1 month ago

I would suggest holding this issue for https://github.com/Expensify/App/pull/47136 - I’m planning to address a couple of Rate-related issues in it holistically. Currently we are discussing potential BE changes that will help eliminate multiple existing bugs easier.

melvin-bot[bot] commented 1 month ago

@Pujan92, @sonialiap, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 4 weeks ago

@Pujan92 @sonialiap @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 4 weeks ago

@Pujan92, @sonialiap, @mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 weeks ago

@Pujan92, @sonialiap, @mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

mallenexpensify commented 3 weeks ago

Thanks @paultsimura , put on hold, removed Help Wanted

melvin-bot[bot] commented 3 weeks ago

@Pujan92, @sonialiap, @mallenexpensify 10 days overdue. I'm getting more depressed than Marvin.