search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

[Hold for payment 2024-09-06] [#wave-control] [Bring copilot to NewDot] Display account switcher #46920

Closed dangrous closed 1 month ago

dangrous commented 2 months ago

Part of the Bring copilot to NewDot project

Main issue: https://github.com/Expensify/Expensify/issues/382866 Doc section: https://docs.google.com/document/d/18G6J5bl61VnVa5CoKpRXhM0MhkXDwpm87GVitZrSCVg/edit#heading=h.4gw8y2nhd2we Project: https://github.com/orgs/Expensify/projects/130

Feature Description

Manual Test Steps

Automated Tests

dangrous commented 2 months ago

assigning myself for review once it's ready

parasharrajat commented 2 months ago

Need access to the design doc @dangrous

rushatgabhane commented 2 months ago

Popover bug to fix LATER: https://github.com/Expensify/App/pull/47338#issuecomment-2313666208

IOS: BUG: While offline, Alert does not show up on changing accounts.

dangrous commented 1 month ago

Okay just listing out the additional bugs found so far here. I think we expected there was going to be weirdness, so no worries, but definitely should look into it.

BUGS BEHIND BETA

BUGS CURRENTLY VISIBLE

The second section here is the priority, I think, but they're pretty much all visual quick fixes, nothing too crazy. @rushatgabhane do you think you could fix 'em all in one go?

The ones that are bugs with the copilot feature itself, I think we can probably just include those in the future copilot PRs, rather than doing them separately. Let me know if you disagree.

rushatgabhane commented 1 month ago

@dangrous sounds good

dangrous commented 1 month ago

@parasharrajat assigning you here since you reviewed, will grab a BZ for payment when ready!

parasharrajat commented 1 month ago

Can we please process the C+ payment here? @dangrous Please assign someone.

dangrous commented 1 month ago

oops yep will do!

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

dangrous commented 1 month ago

hey @sonialiap! @parasharrajat reviewed this PR as the C+, so will need payment; @rushatgabhane is getting handled at the project level so I believe no payment needed for them right now. We're through the 7 day period also!

sonialiap commented 1 month ago

Thanks Dan :D

sonialiap commented 1 month ago

went to production Aug 30, payment should have been Sep 6 😳

sonialiap commented 1 month ago

Payment summary

parasharrajat commented 3 weeks ago

Payment requested as per https://github.com/Expensify/App/issues/46920#issuecomment-2368307458

JmillsExpensify commented 3 weeks ago

$250 approved for @parasharrajat