Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

"User Profiling" Toggle Not Working #46929

Closed IuliiaHerets closed 2 months ago

IuliiaHerets commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.17-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): abebemiherat@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Sign in to the new dot.
  2. Click on Ctrl + D.
  3. Observe that the modal appears.
  4. Attempt to toggle the 'User Profile' and notice that it does not work.

Expected Result:

The user should be able to toggle the 'User Profile'.

Actual Result:

The user is unable to toggle the 'User Profile'.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/c6bf7420-24bc-4264-90d2-f262f01af52b

View all open jobs on GitHub

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 3 months ago

We think that this bug might be related to #wave-collect - Release 1

marcaaron commented 3 months ago

The user should be able to toggle the 'User Profile'.

Sorry, did you mean Use Profiling ?

Gonna remove the blocker here. This is an internal tool and not mission critical.

IuliiaHerets commented 3 months ago

@marcaaron Yes, Use Profiling, sorry for confusing

Tony-MK commented 3 months ago

This is issue doesn't actually occur on the main branch

zanyrenney commented 3 months ago

2024-08-07_14-58-18 (1)

can reproduce on staging

zanyrenney commented 3 months ago

but i agree this is not critical

zanyrenney commented 3 months ago

do we actually do this? @thienlnam I see only one ever mention of "user profiling" in slack and its in reference to iOS:

2024-08-07_15-01-48
zanyrenney commented 3 months ago

asking here https://expensify.slack.com/archives/C05LX9D6E07/p1723039606440559

kirillzyusko commented 3 months ago

It happens because "hosting" is not allowing "self-profiling":

Document policy violation: js-profiling is not allowed in this document.

I described it here: https://github.com/margelo/react-native-release-profiler?tab=readme-ov-file#web-support

We enabled this toggle in dev mode, but to enable it in prod (staging and prod) you'll need to add 'Document-Policy': 'js-profiling' header to html response.

I don't have permissions to deploy so I can not fix it, but if someone can shed some light on where and how the app is hosted (is it AWS S3?) then I can co-operate with that person and together we can fix that 🤞

zanyrenney commented 3 months ago

Hey @thienlnam any progress here please? I see you added the Infra label - what's the intention for that to assign a specific person/group so that we can move this forward or are you still able to manage it?

thienlnam commented 3 months ago

Bumped this back to a weekly since it's not high priority.

I need to double check where we want to add this header - chances are it will probably be in our salt config

thienlnam commented 2 months ago
Screenshot 2024-08-23 at 9 23 33 AM

Nice, resolved! We only added this to staging and adhoc builds