search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[Landing page] Clean up items from testing #46953

Closed trjExpensify closed 1 week ago

trjExpensify commented 1 month ago

Linking these from the testing thread for a reference to track making progress on fixing them.

melvin-bot[bot] commented 1 month ago

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

carlosmiceli commented 1 month ago

On my list.

carlosmiceli commented 1 month ago

Adding this one too to check in case it happens when we go full prod: https://expensify.slack.com/archives/C036QM0SLJK/p1723226584559989?thread_ts=1723147538.433649&cid=C036QM0SLJK

carlosmiceli commented 1 month ago

Should be done today with the last item, and a few more things I found to fix 🤞

trjExpensify commented 1 month ago

Just so I'm following, that's this one?

Console error when entering in a phone number. Seems to still work though, I got the magic code on SMS. (This is a phone number that has an account already).

carlosmiceli commented 1 month ago

Correct! But I discovered a couple more issues while fixing that one.

carlosmiceli commented 1 month ago

Also need to check that this is fixed with the upcoming PR: https://expensify.slack.com/archives/C03U7DCU4/p1723665847506339

carlosmiceli commented 1 month ago

PR is ready, need to finish description and test steps. @trjExpensify question: should we wait until QA is over to go to 50%, or can we increase it as soon as it's merged?

trjExpensify commented 4 weeks ago

That PR has a fair few fixes, let's get it through QA and then bump to 50%.

carlosmiceli commented 4 weeks ago

The PR is officially ready for review/merge: https://github.com/Expensify/Web-Expensify/pull/43120

melvin-bot[bot] commented 3 weeks ago

@carlosmiceli, @trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

trjExpensify commented 2 weeks ago

All PRs in this issue are done now right, so we can close?

mallenexpensify commented 2 weeks ago

What about this one?

Trying to figure out the next steps. I unassigned @carlosmiceli cuz they were auto-assigned via Improvement, should I re-add you @carlosmiceli ?

trjExpensify commented 2 weeks ago

That's being tracked as an individual issue. Carlos said he was looking into yeah, so reassign. 👌

melvin-bot[bot] commented 1 week ago

@carlosmiceli, @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 1 week ago

All PRs in this issue are done now right, so we can close?

I believe that's a yes, closing.