[Awaiting payment] [$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.17-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two same distance expenses.
4. Go to transaction thread of any submitted expense.
5. Click Review duplicates.
6. Click Keep this one (any).
7. Proceed to confirmation page.
8. Click Rate.

Expected Result:

Distance rate should not be editable on the confirmation page (like other fields).

Actual Result:

Distance rate is editable on the confirmation page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/20efdbcb-969a-495e-a47c-8d2eed7028f0

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa94659fe7b3028a
• Upwork Job ID: 1821151696845785168
• Last Price Increase: 2024-08-07
• Automatic offers:
• ishpaul777 | Reviewer | 103588098
• dominictb | Contributor | 103588104

[melvin-bot[bot]]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate is editable on the confirmation page

What is the root cause of that problem?

In MoneyRequestview we are only checking canEditDistanceRate prop before we are making the button interactive and displaying right icon https://github.com/Expensify/App/blob/2c60fc937881a77062f0e07a405fa0380cc847b3/src/components/ReportActionItem/MoneyRequestView.tsx#L349-L353

What changes do you think we should make in order to solve the problem?

We should check for readonly prop too

interactive={canEditDistanceRate && !readonly}
shouldShowRightIcon={canEditDistanceRate && !readonly}

Note: We can check other menuItems on MoneyRequestView and apply the change to prevent this issue happening on other menu items

What alternative solutions did you explore? (Optional)

[etCoderDysto]

I can raise a quick PR if needed.

[trjExpensify]

@pecanoro dupe detection is behind a beta, this isn't a deploy blocker right?

[pecanoro]

Yes, removing the blocker

[pecanoro]

This one is also pretty easy so I am going to change the initial price to $125

[trjExpensify]

Perf, thanks!

[trjExpensify]

Adding External to get a C+ assigned to review https://github.com/Expensify/App/issues/46954#issuecomment-2273158439.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01aa94659fe7b3028a

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[melvin-bot[bot]]

Upwork job price has been updated to $125

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate is editable on the confirmation page.

What is the root cause of that problem?

We are using canEditDistanceRate to check if the rate field is editable or not: https://github.com/Expensify/App/blob/2c60fc937881a77062f0e07a405fa0380cc847b3/src/components/ReportActionItem/MoneyRequestView.tsx#L352-L353 with: https://github.com/Expensify/App/blob/2c60fc937881a77062f0e07a405fa0380cc847b3/src/components/ReportActionItem/MoneyRequestView.tsx#L194

What changes do you think we should make in order to solve the problem?

We should update: https://github.com/Expensify/App/blob/2c60fc937881a77062f0e07a405fa0380cc847b3/src/components/ReportActionItem/MoneyRequestView.tsx#L182 to:

    const canUserPerformWriteAction = !!ReportUtils.canUserPerformWriteAction(report) && !readonly;

The variable name canUserPerformWriteAction suggests it should determine whether the report is editable. However, the condition canUserPerformWriteAction && !readonly is applied to each field, resulting in redundant logic that can lead to oversights, as seen in this issue. This redundancy suggests that canUserPerformWriteAction isn't fully serving its intended purpose, as it should be sufficient to control editability without requiring additional checks.

With my above solution, we can remove all the redundant check !readonly in entire the file.

[ishpaul777]

While RCA and solution from @etCoderDysto is correct, I prefer going with @dominictb solution as it suggests a hollistic and more future error proof approach.

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[ishpaul777]

not overdue, Pending a final proposal review

[sakluger]

@pecanoro this one is waiting for your review. Thanks!

[sakluger]

Rocio is on vacation until next week - she'll review once she's back.

[pecanoro]

Just came back today, thank you for waiting! Assigning @dominictb to the issue

[melvin-bot[bot]]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[ishpaul777]

Ready for payment 🎉

[sakluger]

Summarizing payment on this issue:

Contributor: @dominictb $125, paid via Upwork Contributor+: @ishpaul777 $125, paid via Upwork

@ishpaul777 do we need regression steps or are we good as is?

[melvin-bot[bot]]

@sakluger @pecanoro @ishpaul777 @dominictb this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[sakluger]

Friendly bump @ishpaul777 I think we may need a regression test for this one.

[ishpaul777]

Regression Test proposal

1. Go to newdot
2. Go to workspace chat.
3. Submit two same distance expenses.
4. Go to transaction thread of any submitted expense.
5. Click Review duplicates.
6. Click Keep this one (any).
7. Proceed to confirmation page.

Expected Result: There should not be any field that is editable. All fields should be read only

Do we agree 👍 or 👎

[sakluger]

Looks great, thanks!