Closed IuliiaHerets closed 1 week ago
Triggered auto assignment to @marcochavezf (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @stephanieelliott (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
We think that this bug might be related to #vip-vsb
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
I can repro this, not responding to the input at all:
https://github.com/user-attachments/assets/0c9a36fc-19b5-4213-af98-8a250eef45bf
Looking at the deploy checklist, thinking maybe https://github.com/Expensify/App/pull/46409? @TMisiukiewicz @adhorodyski @mkhutornyi?
FWIW, from testing this it seems isolated to group chat > members > invite members and the bug is not on production.
Looking at the deploy checklist, thinking maybe https://github.com/Expensify/App/pull/46409?
Git bisect led me to the same PR https://github.com/Expensify/App/pull/46409, creating a revert PR in a moment
It's a pretty big PR that. Do we know why there's a problem here with the groups members page only? I'm wondering if we want to get a fix up for that, instead of a full revert.
In fact, I think we should probably not block on this. The perf gains in the core flows (start chat, submit expense etc) aren't worth reverting for this bug in the groups members page which aren't really utilised much right now.
Removing getSearchText speeds up creating option list by around 40%. In the context of a trace provided for a linked issue, it reduces accumulated createOption time from 5.7s to 4s (~42% improvement)
So maybe we demote, and @adhorodyski @TMisiukiewicz can look into the fix as a Daily
?
@trjExpensify I'll take care of it today 👍
@trjExpensify me or the other Adam? 😄 @adhorodyski
Adam H, my bad!
haha sure thing, please see https://github.com/Expensify/App/pull/47051 - I believe this should be enough to avoid reverting:)
PR open ✅
Thanks, added @hoangzinh to the issue for the C+ review!
PR is on staging!
This was deployed to prod on the 16th per https://github.com/Expensify/App/issues/47356 -- updating with payment labels!
Summarizing payment on this issue:
Contributor+: @hoangzinh $250 via Upwork - PAID
Upwork job is here: https://www.upwork.com/jobs/~01377f35a0f0d576f7
Accepted. Thanks @stephanieelliott
Thanks @hoangzinh, all paid!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.17-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The results are not filtered. Nothing happens after searching for a member.
Actual Result:
The relevant results will come up.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/772a3be9-b923-4df4-a132-4bb621f38c3d
View all open jobs on GitHub