[HOLD for payment 2023-08-23] Group chat - Unable to search for members when inviting group members

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.32k stars 2.75k forks source link

[HOLD for payment 2023-08-23] Group chat - Unable to search for members when inviting group members #46972

Closed IuliiaHerets closed 1 week ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.17-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to a group chat.
Click on the chat header.
Click Members.
Click Invite member.
Search with a valid term.

Expected Result:

The results are not filtered. Nothing happens after searching for a member.

Actual Result:

The relevant results will come up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/772a3be9-b923-4df4-a132-4bb621f38c3d

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 month ago

We think that this bug might be related to #vip-vsb

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

trjExpensify commented 1 month ago

I can repro this, not responding to the input at all:

https://github.com/user-attachments/assets/0c9a36fc-19b5-4213-af98-8a250eef45bf

Looking at the deploy checklist, thinking maybe https://github.com/Expensify/App/pull/46409? @TMisiukiewicz @adhorodyski @mkhutornyi?

trjExpensify commented 1 month ago

FWIW, from testing this it seems isolated to group chat > members > invite members and the bug is not on production.

marcochavezf commented 1 month ago

Looking at the deploy checklist, thinking maybe https://github.com/Expensify/App/pull/46409?

Git bisect led me to the same PR https://github.com/Expensify/App/pull/46409, creating a revert PR in a moment

trjExpensify commented 1 month ago

It's a pretty big PR that. Do we know why there's a problem here with the groups members page only? I'm wondering if we want to get a fix up for that, instead of a full revert.

trjExpensify commented 1 month ago

In fact, I think we should probably not block on this. The perf gains in the core flows (start chat, submit expense etc) aren't worth reverting for this bug in the groups members page which aren't really utilised much right now.

Removing getSearchText speeds up creating option list by around 40%. In the context of a trace provided for a linked issue, it reduces accumulated createOption time from 5.7s to 4s (~42% improvement)

So maybe we demote, and @adhorodyski @TMisiukiewicz can look into the fix as a Daily?

TMisiukiewicz commented 1 month ago

@trjExpensify I'll take care of it today 👍

adamgrzybowski commented 1 month ago

@trjExpensify me or the other Adam? 😄 @adhorodyski

trjExpensify commented 1 month ago

Adam H, my bad!

adhorodyski commented 1 month ago

haha sure thing, please see https://github.com/Expensify/App/pull/47051 - I believe this should be enough to avoid reverting:)

TMisiukiewicz commented 1 month ago

PR open ✅

trjExpensify commented 1 month ago

Thanks, added @hoangzinh to the issue for the C+ review!

stephanieelliott commented 3 weeks ago

PR is on staging!

stephanieelliott commented 3 weeks ago

This was deployed to prod on the 16th per https://github.com/Expensify/App/issues/47356 -- updating with payment labels!

stephanieelliott commented 2 weeks ago

Summarizing payment on this issue:

Contributor: @TMisiukiewicz no payment due (agency)
Contributor+: @hoangzinh $250 via Upwork - PAID

Upwork job is here: https://www.upwork.com/jobs/~01377f35a0f0d576f7

hoangzinh commented 2 weeks ago

Accepted. Thanks @stephanieelliott

hoangzinh commented 2 weeks ago

BugZero Checklist:

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/46409
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: PR author already raised a PR to fix it https://github.com/Expensify/App/issues/46972#issuecomment-2275035120 so no need to comment on the offending PR anymore
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug: ⛔ I'ts a DB so I think we already have regression test for this issue.

stephanieelliott commented 1 week ago

Thanks @hoangzinh, all paid!