[$250] Distance - App crashes when deleting a distance expense when there are two distance expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: .0.17-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): sarahhailu1268+dhsdfsdhgshg@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to the staging app with a new account
2. Create a new workspace
3. Go to FAB > Submit Expense > Distance
4. Enter start and finish waypoints > Submit it to the workspace
5. Again go to FAB > Submit Expense > Distance
6. Enter start and finish waypoints > Submit it to the workspace
7. After the expenses are created go into the combined report and click on the first expense
8. Click on the header > Delete expense > Confirm

Expected Result:

The app will not crash and the expense is successfully deleted

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/57f7d4e0-f012-4cb0-9cae-b8bd42181cce

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183948967c6155377
• Upwork Job ID: 1821209382283102288
• Last Price Increase: 2024-08-14
• Automatic offers:
• dominictb | Contributor | 103641053

Issue Owner

Current Issue Owner: @dominictb

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0183948967c6155377

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-08-07 15:46:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when deleting a distance expense when there are two distance expenses

What is the root cause of that problem?

When deleting a distance request tags become undefined here https://github.com/Expensify/App/blob/0a33186c80eb821d67d75b44bca527640204852c/src/libs/OptionsListUtils.ts#L1355-L1356

What changes do you think we should make in order to solve the problem?

We should use nullish coalescing operator to return empty array when tags is undefined in Ojbect.values

const policyTagValueList = policyTagList.map(({tags}) => Object.values(tags ?? [])).flat();

What alternative solutions did you explore? (Optional)

Result:

https://github.com/user-attachments/assets/c84c2d01-fb82-4c0f-8bcd-20476a216ad6

[etCoderDysto]

Updated Proposal

• Added video result

[Amoralchik]

What is the root cause of that problem?

The data we are working with in hasEnabledTags might be an array of objects, with the first key being Tag.

Because of this, destructuring {tags} in policyTagList returns undefined. https://github.com/Expensify/App/blob/0a33186c80eb821d67d75b44bca527640204852c/src/libs/OptionsListUtils.ts#L1356

In most cases, this doesn't cause problems because in:

https://github.com/Expensify/App/blob/195691e2c231e559e21470fc5fa547bc0f3e51bc/src/components/ReportActionItem/MoneyRequestView.tsx#L201

we rely on isPolicyExpenseChat or transactionTag. However, when neither is present, it falls back to hasEnabledTags.

So why? I don't know, unfortunately, after clearing the cache I can no longer reproduce this bug. This fix might work, but I want to understand why the user might receive a list like the one in the screenshot. I'll keep investigating, as I think the problem might be much larger. Anyway, if I find anything, I'll let you know.

[dominictb]

Edited by proposal-police: This proposal was edited at 2024-08-08 10:22:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes.

What is the root cause of that problem?

• This issue occurs when the app's Onyx data contains report_undefined data. Suppose the app has:

  report_undefined: {reportName: "Chat Report"}

  and we are on an expense report page with two distance expenses. In this scenario, the transactionThreadReportID in: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/pages/home/ReportScreen.tsx#L342-L345 is undefined. However, because report_undefined has the value {reportName: "Chat Report"}, the condition at: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/pages/home/report/ReportActionItemContentCreated.tsx#L151 is still true, so the component at: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/pages/home/report/ReportActionItemContentCreated.tsx#L162-L165 is displayed in the expense report.

• Consequently, the policyTagLists data in: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/components/ReportActionItem/MoneyRequestView.tsx#L674-L674 might look like this (retrieving all tags data from all policies rather than just the target policy):

  {
    "policyTags_AAF1F0C56F4E3906": {
        "Tag": {
            "name": "Tag",
            "orderWeight": 0,            
            "tags": []
        }
    },
    "policyTags_59758A8741EE68F2": {
        "Tag": {
            "name": "Tag",
            "orderWeight": 0,
            "tags": []
        }
    }
  }

• Now, if the logic OptionsListUtils.hasEnabledTags(policyTagLists) is executed at: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/components/ReportActionItem/MoneyRequestView.tsx#L212, the app will crash. However, because isPolicyExpenseChat is false, OptionsListUtils.hasEnabledTags(policyTagLists) is not called.

• When the first expense is deleted, the transactionThreadReportID is no longer undefined, and the transactionThreadReport is updated. At this point: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/components/ReportActionItem/MoneyRequestView.tsx#L212, isPolicyExpenseChat becomes true, and since OptionsListUtils.hasEnabledTags(policyTagLists) is called with outdated policyTagLists data, the app crashes.

What changes do you think we should make in order to solve the problem?

• Ensure that there is no report_undefined Onyx data. In my RCA, I noted that report_undefined can appear when we call: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/pages/iou/request/step/IOURequestStepDistance.tsx#L217.

• Update the following code: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/pages/iou/request/step/IOURequestStepDistance.tsx#L217 to:

  Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_WAYPOINT.getRoute(action, CONST.IOU.TYPE.SUBMIT, transactionID, report?.reportID ?? reportID, index.toString(), Navigation.getActiveRoute()));

  In this update, I added the fallback value report?.reportID ?? reportID to ensure the report parameter in ROUTES.MONEY_REQUEST_STEP_WAYPOINT is not undefined.

What alternative solutions did you explore? (Optional)

• We can update this condition: https://github.com/Expensify/App/blob/53eee53ac8bfbdfd4d8eeaf16940e3b165483373/src/pages/home/report/ReportActionItemContentCreated.tsx#L151 to:

  {transactionThreadReport.reportID && transactionThreadReport && !isEmptyObject(transactionThreadReport) ? (

[dominictb]

Proposal updated

[melvin-bot[bot]]

@mollfpr, @greg-schroeder Eep! 4 days overdue now. Issues have feelings too...

[trjExpensify]

@mollfpr can you review this proposal, please?

[greg-schroeder]

Yes, awaiting proposal review

[mollfpr]

Reviewing 👀

[mollfpr]

@etCoderDysto @dominictb Do you guys still able to reproduce the issue?

[etCoderDysto]

@mollfpr I am not able to reproduce this.

[dominictb]

@mollfpr Actually, with the OP's reproduce steps, I cannot reproduce. But based on my RCA, I still can reproduce the bug if there is report_undefined key in onyx.

[dominictb]

To create a report_undefined key in onyx, we can just go to this url https://dev.new.expensify.com:8082/r/undefined

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

@dominictb I didn't get the crash on staging with the above suggestion.

[dominictb]

@mollfpr Here is the video from my side:

https://github.com/user-attachments/assets/8330c078-a65b-441d-9938-61dbf15c6677

[mollfpr]

@dominictb I can reproduce the issue now and it seems your RCA is correct.

We can go with @dominictb proposal's but using both main and alternative solution.

🎀 👀 🎀 C+ reviewed!

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

@mollfpr @greg-schroeder @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dominictb]

@aldo-expensify Can you help review my proposal above?

[melvin-bot[bot]]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[dominictb]

Just want to note the reproduce steps for this bug:

1. Paste this url to any chat https://dev.new.expensify.com:8082/r/undefined.
2. Click on the above url message.
3. Submit 2 expenses to any workspace.
4. Click on the report preview in step 3.
5. Delete the first message.
6. Verify app is crashed.

[greg-schroeder]

PR is in review, next up is @mollfpr!

[greg-schroeder]

PR still going through review

[greg-schroeder]

Bump @aldo-expensify I believe you're up for a re-review here?

[aldo-expensify]

Thank you, I had missed the notification before. PR merged.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @mollfpr, @greg-schroeder, @aldo-expensify, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

PR hit staging yesterday, Melv.

[greg-schroeder]

Just awaiting deploy to prod!