Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

[$250] Accounting - Xero syncing stuck on Checking Xero connection & it shown connected after relogin #46989

Closed lanitochka17 closed 4 days ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.17.1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/46480

Action Performed:

  1. Open the app and log in
  2. Open the workspace settings
  3. Tap More features and enable Accounting
  4. Navigate to Accounting and select Xero integration
  5. Enter Xero credentials
  6. Wait for Xero to complete syncing

Expected Result:

Xero is connected and the message "Last synced <> minutes ago" is displayed

Actual Result:

Xero syncing is stuck on "Checking Xero connection", and the integration is only shown as connected after re-login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/13699d8d-0a9b-4579-b15e-2d4bec2a4717

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0140eb31cd35ebadc8
  • Upwork Job ID: 1825754480856760461
  • Last Price Increase: 2024-09-03
Issue OwnerCurrent Issue Owner: @rojiphil
lanitochka17 commented 1 month ago

We think that this bug might be related to #wave-collect - Release 2

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

RachCHopkins commented 1 month ago

No problem for me on web:

image

Mobile is borked, so I will have to attempt again on Monday.

melvin-bot[bot] commented 1 month ago

@RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 4 weeks ago

@RachCHopkins Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 3 weeks ago

@RachCHopkins 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

RachCHopkins commented 3 weeks ago

Sorry, last week was a total write-off. Just picked this up again. It's definitely sitting on "syncing customers" for a long time. IMG_3898

manager.rach+BZ@expensicorp.com is my testing account. Workspace ID 8CEDF0D4BB7FC051.

When I go into OldDot suppotal, it's ready to configure:

image

Logs definitely indicate that the job is "complete"

image

And my app still says syncing customers. Something is not updating the app end.

melvin-bot[bot] commented 3 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~0140eb31cd35ebadc8

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

melvin-bot[bot] commented 3 weeks ago

@rojiphil @RachCHopkins this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 2 weeks ago

@rojiphil, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 2 weeks ago

@rojiphil, @RachCHopkins Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 2 weeks ago

@rojiphil, @RachCHopkins 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

trjExpensify commented 2 weeks ago

CC: @hungvu193 @arosiclair I wonder if this is related to the recent sync woes with Xero.

hungvu193 commented 2 weeks ago

I don't think so but let me take a look

hungvu193 commented 2 weeks ago

Is this issue account-specific? I don't think I can reproduce it. (Please ignore the error at the end, we had a PR to fix it already).

https://github.com/user-attachments/assets/cca03f0d-665a-477f-8311-c3a9a3d97477

trjExpensify commented 2 weeks ago

Maybe, or we fixed it! @RachCHopkins can you retest on your account?

arosiclair commented 1 week ago

CC: @hungvu193 @arosiclair I wonder if this is related to the recent sync woes with Xero.

Don't think so either. Seems to be more-so an issue with some connection sync progress updates not being received. Or possibly the app just isn't re-rendering with those updates.

melvin-bot[bot] commented 1 week ago

@rojiphil, @RachCHopkins 12 days overdue. Walking. Toward. The. Light...

trjExpensify commented 1 week ago

CC: @hungvu193 @arosiclair I wonder if this is related to the recent sync woes with Xero.

Don't think so either. Seems to be more-so an issue with some connection sync progress updates not being received. Or possibly the app just isn't re-rendering with those updates.

Alright cool, well maybe let's start with a repro on this account of Rach's and see if we can go from there if it's reliably reproducible using that account.

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

rojiphil commented 1 week ago

Alright cool, well maybe let's start with a repro on this account of Rach's and see if we can go from there if it's reliably reproducible using that account.

Yeah. I too can't reproduce this. Here is a test video demonstrating this. Maybe we can close this out.

https://github.com/user-attachments/assets/3fd16be3-05b5-4955-aabd-0d6dfed0176d

melvin-bot[bot] commented 1 week ago

@rojiphil @RachCHopkins this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 6 days ago

@rojiphil, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

RachCHopkins commented 4 days ago

Completely different experience this time. Lightening fast, no waiting for anything. I think we can close this out!