Closed IuliiaHerets closed 1 month ago
Triggered auto assignment to @stephanieelliott (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @pecanoro (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive β± issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
We think that this bug might be related to #vip-vsb
I can reproduce but if it's not coming from the back-end, I am wondering if we changed the API request in some PR, looking!
Oh, on production we call TrackExpense
and we call CreateDistanceRequest
on staging
It's coming from this PR: https://github.com/Expensify/App/pull/42302
I am going to open it for proposals since everyone involved in the original PR is not online and if we don't get any, I will revert the original PR.
Job added to Upwork: https://www.upwork.com/jobs/~018888d22189418e67
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External
)
Edited by proposal-police: This proposal was edited at 2024-08-08 11:42:06 UTC.
@pecanoro I can raise the PR asap to fix this
App throws error when submitting track distance expense - There is a previously existing chat between these users.
In the PR https://github.com/Expensify/App/pull/42302, we mistakenly moved the createDistanceRequest(iouType ==
condition to the top (this change https://github.com/Expensify/App/pull/42302/files#diff-5e5fc302dd5db871d26e30f810bc0606beccb7f50ae6ed6535cd93aaee98c280), causing it to be evaluated first and not trackExpense
, so it calls CreateDistanceRequest
in track distance expense case instead of TrackExpense
Move this block back to its correct location before the PR which is here https://github.com/Expensify/App/blob/0926267c22e50e68b52c055dacc3af775235ccd4/src/pages/iou/request/step/IOURequestStepConfirmation.tsx#L505
Update this block to
if (iouType !== CONST.IOU.TYPE.TRACK && isDistanceRequest && !isMovingTransactionFromTrackExpense) {
createDistanceRequest(iouType === CONST.IOU.TYPE.SPLIT ? splitParticipants : selectedParticipants, trimmedComment);
return;
}
So it will only createDistanceRequest
if it's not a track expense, we can extend the iouType
check for other iou types if needed (if there're other IOU types that should not call createDistanceRequest
but uses its own method, like track expense)
Proposal updated to add alternative approach
Hmm, I don't think we can just move createDistanceRequest
back down as that would most likely cause a regression from https://github.com/Expensify/App/pull/42302 since we'd call IOU.splitBill
first and return early instead of creating the distance request for splitting.
~I wonder if we also need to handle~ !isMovingTransactionFromTrackExpense
covers the other conditions that result in calling trackExpense
:
Having investigated further, it looks like @dominictb's alternative solution is the way to go here.
:ribbon::eyes::ribbon: C+ reviewed
Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
Thanks @jjcoffee for the review, @pecanoro Can you assign me to the issue so I can raise the PR asap?
Sounds good, assigning @dominictb
π£ @jjcoffee π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @dominictb π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Thanks π On it now
Awesome, thank you! Removing deploy blocker
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.18-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Summarizing payment on this issue:
Contributor+: @jjcoffee $250 via Upwork - PAID
Upwork job is here: https://www.upwork.com/jobs/~018888d22189418e67
Hey @jjcoffee can you please complete the BZ checklist for this when you get a sec?
Regression Test Proposal
Do we agree π or π
Test case created! https://github.com/Expensify/Expensify/issues/422130
All done here, thanks!
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.18-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The track distance expense will be created successfully.
Actual Result:
App throws error when submitting track distance expense - There is a previously existing chat between these users.
Workaround:
Uncnown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/a931bfe2-a93e-44a0-8554-79800bbba54f
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @stephanieelliott