Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

Sign in – Blank page opens when login via magic link and click on Just sign in here #47053

Closed IuliiaHerets closed 3 weeks ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4834115 Email or phone of affected tester (no customers): applausetester+jp_48824@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. In Sign in page enter new Expensify email
  3. Open email and copy Magic link
  4. In Incognito tab navigate via Magic link changed to staging
  5. Click on Just sign in here link

Expected Result:

User is logged in

Actual Result:

Blank page opens

Workaround:

Anknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/09859e5b-a53e-4622-98f4-078de4bf7e63

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 1 month ago

We think that this bug might be related to #vip-vsb

danieldoglas commented 1 month ago

@iwiznia and I were not able to simulate this error.

@IuliiaHerets can you please retest this and rewrite the reproduction steps if you can still see it happening?

Thanks

iwiznia commented 1 month ago

The video makes it seem that you pasted the magic link into an incognito browser that already has a user logged in in another tab.

dangrous commented 1 month ago

if this turns out to be a bug it might be due to https://github.com/Expensify/App/pull/46623 since seems related?

danieldoglas commented 3 weeks ago

Closing this. We were not able to simulate, and this flow is being worked on another issues already.