Closed IuliiaHerets closed 3 weeks ago
Triggered auto assignment to @mountiny (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @twisterdotcom (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive โฑ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
We think that this bug might be related to #vip-split
Tax code and amount is empty when creating split distance request.
When we are creating a split distance, it will call createSplitsAndOnyxData
.
https://github.com/Expensify/App/blob/0926267c22e50e68b52c055dacc3af775235ccd4/src/libs/actions/IOU.ts#L5020-L5040
However, we don't pass the tax code and amount to createSplitsAndOnyxData
.
Pass both tax code and amount to createSplitsAndOnyxData
.
const {
splitData,
splits,
onyxData: splitOnyxData,
} = createSplitsAndOnyxData(
...,
CONST.IOU.REQUEST_TYPE.DISTANCE,
taxCode,
taxAmount,
);
@mountiny is this right? I think we could just assign @bernhardoj now if so. I don't think we need to block a deploy with this as it's not an error, it's just unexpected behavior from a less frequently used flow.
Job added to Upwork: https://www.upwork.com/jobs/~01d1cb3838667f8739
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External
)
Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
Sounds good
๐ฃ @situchan ๐ An offer has been automatically sent to your Upwork account for the Reviewer role ๐ Thanks for contributing to the Expensify app!
PR is ready
cc: @situchan
PR is deployed to prod a week ago. This should be ready for payment.
Requested in ND.
Awaiting payment summary
Payment Summary:
$250 approved for @bernhardoj
If you havenโt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.18-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
Tax rate and Tax reclaimable have the correct info in the transaction thread.
Actual Result:
Tax rate and Tax reclaimable are empty in the transaction thread.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/79544b96-21f6-43e6-89e3-6a19c9f281cb
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twisterdotcom