Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

Add SAML Setup #47068

Open twisterdotcom opened 1 month ago

twisterdotcom commented 1 month ago

Design Doc HERE

Proposal

Proposal: Add SAML configuration to New Expensify

Problem: Last year we added user SAML SSO last year to newDot to allow access to Expensify for controlled users on SAML Required domains, but SAML configuration currently still lives solely in Expensify Classic Domains > SAML settings, meaning any #wave-control domain admin needing to setup, or make requirement and certificate changes is still required to follow the Switch to Expensify Classic flow to configure SAML for their organization.

SAML is also often the major selling point for higher subscription costs in Enterprise SaaS software for all of the benefits it brings and not supporting it's setup in New Expensify means we lose the ability to sell Expensify with those benefits for customers willing to pay top dollar:

Solution:

Let's add SAML configuration to New Expensify and possibly fix some long-standing bugs in the process. Some fun discussions surely to be had on where/how we add this domain feature into NewDot during the predesign.

Slack: https://expensify.slack.com/archives/CC7NECV4L/p1724103770176439

Tasks

melvin-bot[bot] commented 1 month ago

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

melvin-bot[bot] commented 1 month ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

dubielzyk-expensify commented 1 month ago

Let's do it 💪

dubielzyk-expensify commented 3 weeks ago

Let me know if you need anything to get started with this :)

twisterdotcom commented 3 weeks ago

Throwing this here just as a note about services that basically charge more because they have this:

image
twisterdotcom commented 3 weeks ago
image
twisterdotcom commented 3 weeks ago

Doc: https://docs.google.com/document/d/1JP7Tx6g0vPf4mKHzWDeHf5XoAzzw9hNhokNUIJ5Kf9M/edit?usp=sharing

twisterdotcom commented 3 weeks ago

Headed OOO for a bit. Will pick this up when I'm back.

twisterdotcom commented 1 week ago

Predesign here: https://expensify.slack.com/archives/C06ML6X0W9L/p1725445965797999

twisterdotcom commented 4 hours ago

Okay @dubielzyk-expensify, I'll hopefully be looking to post some final screens next week and get the doc out. @dannymcclain has been pretty active here: https://expensify.slack.com/archives/C06ML6X0W9L/p1725446027972499, so not sure if you want to swap out, or if you're fine taking over and we can have a sync early next week? I should be around Monday now I think.