[$250] Report fields - Disabled in ND fields are not deleted in OD

IuliiaHerets commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.18-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3155317 Issue reported by: Applause Internal Team

Action Performed:

Preconditions: Control workspace with all types of Report fields exist.

Navigate to More Features in workspace settings
Disable the Report Fields feature
Confirm the modal so we disable the feature
Login in OD
Go to settings for report fields on the control policy

Expected Result:

All the text and date-type report fields have been deleted. The list-type report field has not been deleted but all its options have been disabled

Actual Result:

All the text and date-type report fields are present. The list-type report field has not been deleted and enabled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/adeb2f68-0aa9-44c5-8289-a3fd2a6c6f97

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018e99bc608dbc484a
Upwork Job ID: 1823257878081571939
Last Price Increase: 2024-08-13

Issue Owner

Current Issue Owner: @suneox

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 months ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 2 months ago

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

dylanexpensify commented 2 months ago

Nice, confirming today!

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~018e99bc608dbc484a

dylanexpensify commented 2 months ago

Forgot to hit external!

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

melvin-bot[bot] commented 2 months ago

@suneox, @mountiny, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

suneox commented 2 months ago

This issue is related to OD and the internal team will handle it, so I’d like to self-unassign.

dylanexpensify commented 2 months ago

Reviewing today!

mountiny commented 2 months ago

Focusing on closing out wave-collect I will see if I can squeeze this one in though

melvin-bot[bot] commented 2 months ago

@mountiny @dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

mountiny commented 2 months ago

Same update as above

mountiny commented 2 months ago

aiming to have PR merged this week

dylanexpensify commented 2 months ago

Sounds good!

mountiny commented 2 months ago

I have been and still am working on a fire fix so this one is coming after the fix is implemented

mountiny commented 2 months ago

Struggling to close the loop on this one with deployer chore, fire fighting and api monitoring chore. Still on top of my list after the most urgent tasks

mountiny commented 2 months ago

Same