Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.89k forks source link

OpenApp fail/partially fails for Jason's heavy approver account on a throttled connection #47093

Closed muttmuure closed 4 weeks ago

muttmuure commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1723132613137659?thread_ts=1722970682.900369&cid=C05LX9D6E07

Action Performed:

Break down in numbered steps

Use an account that approves a lot of reports (@JmillsExpensify's account) Go to new.expensify.com Open the Network console and enable 3G throttling Log in

Expected Result:

Describe what you think should've happened

OpenApp completes successfully and all data is visible in Jason's account

Actual Result:

Describe what actually happened

The app shows a partially loaded state, or nothing is loaded at all

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Using clear cache and restart in the Troubleshoot menu loads the data on a second try

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @francoisl (AutoAssignerNewDotQuality)

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

muttmuure commented 3 months ago

How do I handle an AutoAssignerNewDotQuality issue I've been assigned as part of #newdot-quality?

johncschuster commented 3 months ago

Oh! This is new! Thanks for the SO, Matt! I'll dig into this proper in the AM.

melvin-bot[bot] commented 3 months ago

@francoisl, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster commented 3 months ago

Sorry I haven't gotten to dive into this yet. I've got it on my plate first thing tomorrow.

francoisl commented 2 months ago

Matt's last update in Slack here mentioned that Eduardo from Callstack started investigating this one, should we co-assign?

muttmuure commented 2 months ago

@gedu please could you comment so we can assign you?

johncschuster commented 2 months ago

Bumped in Slack 👍

gedu commented 2 months ago

Hi, I’m Edu from Callstack, I can take a look at this issue

johncschuster commented 2 months ago

Not overdue. This was just assigned.

melvin-bot[bot] commented 2 months ago

@gedu @francoisl @johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

johncschuster commented 2 months ago

@gedu how's this going?

gedu commented 2 months ago

Hey, I found later yesterday, using a slow 4G (on 3G it takes at least 7 - 10 min to "load" the app and then crash), seems like the server didn't sent me reports:

31: key: "report_"onyxMethod: "mergecollection"value: [] 

That was the from the ReconnectApp, so my user ended up with no reports, still looking into this, but seems that could be an issue on the server (?)

gedu commented 2 months ago

Added some thoughts around this on slack (Callstack | Expensify), I couldn’t consistently reproduce the bug.

gedu commented 2 months ago

Discussing about StrictMode on slack

johncschuster commented 2 months ago

Discussion is ongoing in Slack (I've updated the links above to link to both Callstack and Expensify's instances of Slack)

melvin-bot[bot] commented 2 months ago

@gedu, @francoisl, @johncschuster Eep! 4 days overdue now. Issues have feelings too...

johncschuster commented 2 months ago

Discussion in Slack is ongoing (looks like we might be nearing the end 🤞)

johncschuster commented 2 months ago

Ok! It looks like the conversation has come to a conclusion and @gedu should be back to this at the start of next week 🙌

johncschuster commented 2 months ago

Bumping for Melv

melvin-bot[bot] commented 1 month ago

@gedu, @francoisl, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 month ago

@gedu, @francoisl, @johncschuster Still overdue 6 days?! Let's take care of this!

muttmuure commented 1 month ago

PR is where the action is happening https://github.com/Expensify/App/pull/47913

johncschuster commented 1 month ago

Awesome. Thanks, @muttmuure! I'll keep my eyes peeled there for updates

johncschuster commented 1 month ago

@gedu is still working on this. Not overdue!

melvin-bot[bot] commented 1 month ago

@gedu, @francoisl, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster commented 1 month ago

Not overdue. @gedu is regularly working on this (updates in the PR)

francoisl commented 1 month ago

Not overdue, the PR is still being actively worked on.

melvin-bot[bot] commented 1 month ago

@gedu, @francoisl, @johncschuster Huh... This is 4 days overdue. Who can take care of this?

johncschuster commented 1 month ago

Still not overdue. Steady progress is being made in the PR

mountiny commented 1 month ago

Not on hold anymore the dedupe PR was merged

johncschuster commented 1 month ago

Thanks, @mountiny!

mountiny commented 1 month ago

@gedu what are the next steps on this one, do we need to de-dupe the OpenApp?

melvin-bot[bot] commented 1 month ago

@gedu, @francoisl, @johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

johncschuster commented 1 month ago

@gedu bump on the above!

mountiny commented 4 weeks ago

We actually merged this PR https://github.com/Expensify/App/pull/50258 which dedupes the OpenApp so we should be better to test this one again soon

gedu commented 4 weeks ago

Hey, sorry, I don't think there's a specific fix for this one. There were multiple requests failing and some internal errors. Is it still reproducible? Can we get some steps?

mountiny commented 4 weeks ago

I think we can close this one and just see if @JmillsExpensify can still experience these issues and start new more precise investigation if so (not sure if there is much to get out of this one)

JmillsExpensify commented 3 weeks ago

Sounds good to me!