Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.76k forks source link

[$250] [HOLD for Payment 2024-08-26] [Search v2.1] Update Search table to show approver instead of workspace in the `To` column #47166

Closed luacmartins closed 2 weeks ago

luacmartins commented 1 month ago

After an internal discussion, we decided to make the To column in the Search table consistent with OldDot and show the individual approver of the report, instead of the workspace.

Screenshot 2024-08-09 at 5 10 45 PM

Let's update the code to reflect this decision

cc @JmillsExpensify

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015225cf8b5cee59ec
  • Upwork Job ID: 1828282067221197045
  • Last Price Increase: 2024-08-27
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

greg-schroeder commented 4 weeks ago

This was deployed to auth - @luacmartins will there be app or web PRs inc or is this done?

luacmartins commented 4 weeks ago

https://github.com/Expensify/Auth/pull/11910 just mentioned this issue, it doesn't actually solve this. We still need to work on this issue.

luacmartins commented 4 weeks ago

Having said that, I just put up an App PR to fix this

melvin-bot[bot] commented 3 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

ikevin127 commented 3 weeks ago

Note: The above regression is a false alarm for this PR / issue since it's BE related, see context in https://github.com/Expensify/App/issues/47551#issuecomment-2293116051 and confirmation in https://github.com/Expensify/App/issues/47551#issuecomment-2293548674.

⚠️ Automation failed here -> this should be paid on 2024-08-26 according to yesterday’s production deploy from https://github.com/Expensify/App/pull/47091#issuecomment-2296918867.

cc @greg-schroeder

ikevin127 commented 2 weeks ago

cc @greg-schroeder

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~015225cf8b5cee59ec

melvin-bot[bot] commented 2 weeks ago

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

greg-schroeder commented 2 weeks ago

Offer sent for $250 for reviewer role

greg-schroeder commented 2 weeks ago

I'll pay you ASAP as soon as you accept!

ikevin127 commented 2 weeks ago

@greg-schroeder Offer accepted, thanks!

greg-schroeder commented 2 weeks ago

Paid