search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.88k forks source link

[HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173

Closed Julesssss closed 1 month ago

Julesssss commented 2 months ago

Allow editing of attendees on existing requests. The key changes here are that we need to handle editing on the item row, AttendeeSelectionPage, and ensure the policy violation limit is recalculated. Additionally the backend will be creating a system action message containing the details of the edit so we need to pass the attendees to the EditMoneyRequest API and optimistically create the system action message.

Screenshot 2024-08-09 at 15 50 46

Requirements

_More details can be found here and elsewhere throughout the design document_

Julesssss commented 2 months ago

Currently held on the above issues, and is a lower priority task

Julesssss commented 2 months ago

Hey @zfurtak @filip-solecki, for now I'm holding this issue, but feel free to make a start once you need more tasks 👍

Julesssss commented 2 months ago

This will be the last issue worked on.

zfurtak commented 2 months ago

Hi @Julesssss, can you assign me to this one? 😊

Julesssss commented 2 months ago

Sure, done 👍

SzymczakJ commented 1 month ago

FYI I'll be taking this task from Zuzia as she is OOO tomorrow.

SzymczakJ commented 1 month ago

Is there any way to check violation limit for the transaction? The one source would be to take it from transactionViolations object but it's actually given in a string, so if there was another way I would happily use it @Julesssss

Julesssss commented 1 month ago

I think for now we will need to use that string. I will create a backend issue for improving this once we are passing the Onyx data back to the client.

allgandalf commented 1 month ago

@Julesssss Can you please give me access to design doc, I am reviewing this PR, my mail is : whogandalf@gmail.com

Julesssss commented 1 month ago

Hey @allgandalf. I just invited you

allgandalf commented 1 month ago

Thanks, Can you please clear up on the reviewer for that PR, please check here

Julesssss commented 1 month ago

Ah, I see what you mean now.

Switching to @ZhenjaHorbach who has been reviewing and locating bugs in these flows.

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.54-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-05. :confetti_ball:

For reference, here are some details about the assignees on this issue: