search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

Android - Composer - Expand button does not appear when reopening chat with long draft #47224

Closed lanitochka17 closed 2 days ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.19-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to chat
  3. Enter text long enough until expand button appears
  4. Return to LHN
  5. Open the chat in Step 3

Expected Result:

Expand button will appear next to the composer

Actual Result:

Expand button does not appear next to the composer until anything is typed in the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/cb43bf60-2218-44db-b164-5e887258cc1c

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
rlinoz commented 1 month ago

Not a backend issue.

rlinoz commented 1 month ago

I think this is related to https://github.com/Expensify/App/pull/46796, but I don't think it is worth blocking on this.

cc: @hannojg

rlinoz commented 1 month ago

Removing the deploy blocker label because this is an edge case and typing in the composer shows up the expand button again.

hannojg commented 4 weeks ago

Okay, will work on a fix today!

hannojg commented 4 weeks ago

@kirillzyusko is helping with this ticket!

kirillzyusko commented 4 weeks ago

Yep, feel free to assign it to me!

kirillzyusko commented 1 week ago

I prepared a fix https://github.com/Expensify/App/pull/47449

But since we updated RN to the latest version (0.75) earlier - this bug is not reproducible anymore:

https://github.com/user-attachments/assets/6c35dd38-4356-493e-89d0-233afb558b3c

@rlinoz @hannojg @lanitochka17 what are the next steps then? Should we re-test this issue on latest main and if it's not reproducible, then close the issue and close the PR?

hannojg commented 1 week ago

Should we re-test this issue on latest main and if it's not reproducible, then close the issue and close the PR?

Yes, that sounds right!

rlinoz commented 2 days ago

Yep, just tested it in the latest app version and it works fine, let's close this one.

Thanks!