Closed IuliiaHerets closed 1 month ago
Triggered auto assignment to @bfitzexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
We think that this bug might be related to #vip-vsb
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Technical message is displayed when clicking unlink button
Here we pass a key (unlinkLoginForm.linkSent
) to translation content to DotIndicatorMessage
https://github.com/Expensify/App/blob/88ad9c709fc95520520150b7f6f6692c45057267/src/pages/signin/UnlinkLoginForm.tsx#L58-L62
Here we are displaying a key to translation content that is located in en.ts and es.ts rather than fetching the translation content from en.ts and es.ts https://github.com/Expensify/App/blob/de8c7aff0599212afd2875ee0c7cbea3aca40144/src/components/DotIndicatorMessage.tsx#L84-L89
We should call transalte
method with account.message
here
messages={{0: translate(account.message)}}
Secondary contact - Technical message is displayed when clicking unlink button
When we click on unlink button we call - Session.requestUnlinkValidationLink()
We build success data here - https://github.com/Expensify/App/blob/420c2a13cc176dca5adf8dcc8132ef5f8ff678f7/src/libs/actions/Session/index.ts#L787-L825
We directly use unlinkLoginForm.linkSent
(which is key) instead of using the message related to that key.
We should use the message instead of key.
We can use something like - Localize.translateLocal()
for that.
We should for other actions related to unlink
Job added to Upwork: https://www.upwork.com/jobs/~01804377f1573ea50d
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External
)
Will review the proposals by tomorrow. I was OOO.
@etCoderDysto's proposal looks good to me.
π π π C+ reviewed
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @etCoderDysto π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
@mananjadhav, @bfitzexpensify, @stitesExpensify, @etCoderDysto Whoops! This issue is 2 days overdue. Let's get this updated quick!
PR will be ready for review today
@mananjadhav PR is ready for review
@bfitzexpensify This should be ready for payout as I can see it's deployed to production last week. We don't have an offending PR as we never added the fix for this I cannot pinpoint when it should've been added.
I also don't think we need a regression test for this one.
@bfitzexpensify I think this issue is ready for payout. Automation is failing here. It has been more than 7 days since PR was deployed to prod
Payment summary:
$250 to @etCoderDysto - offer sent via Upwork $250 to @mananjadhav - to be paid via manual request
@bfitzexpensify I have accepted the offer. Thanks!
$250 approved for @mananjadhav
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.19-9 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Link sent message should be displayed
Actual Result:
unlinkLoginForm.linkSent
is displayedWorkaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/dd513db6-3115-4cbf-83e7-d4b1c123c39e
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mananjadhav