Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[Payment Due August 22, 2024] [Performance] Use polyfill-force to speed up formatjs #47305

Closed mountiny closed 1 month ago

mountiny commented 2 months ago

Coming from Slack

Proposal: Use polyfill-force to skip the lookup in formatjs which checks whether the platform needs polyfilling

Problem

formatjs checks whether the platform needs polyfilling for the respective polyfilling API. This appears redundant because we mean to have those APIs polyfilled, so we can skip the function shouldPolyfill . Doing so, results in the reduced app startup because we are skipping the lookup function shouldPolyfill.

Solution

We are already using polyfill-force for some polyfills but not for all of them. So we just have to add it to others, for eg, require('@formatjs/intl-locale/polyfill-force');

The PR with the changes is here .

Issue OwnerCurrent Issue Owner: @anmurali
melvin-bot[bot] commented 2 months ago

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

hurali97 commented 2 months ago

@mountiny Please assign this to me

melvin-bot[bot] commented 2 months ago

@Beamanator, @anmurali, @hurali97, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

ishpaul777 commented 2 months ago

Deployed 5 days ago, Paydue 22/8

Screenshot 2024-08-20 at 11 55 29 PM
ishpaul777 commented 2 months ago

ready for payment

melvin-bot[bot] commented 2 months ago

@Beamanator, @anmurali, @hurali97, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 month ago

@Beamanator, @anmurali, @hurali97, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

ishpaul777 commented 1 month ago

Ready for payment

ishpaul777 commented 1 month ago

gentle bump @anmurali @Beamanator ^ 🙇

Beamanator commented 1 month ago

Updated title to Awaiting Payment! 🙏

anmurali commented 1 month ago

Paid.