Open IuliiaHerets opened 1 month ago
Triggered auto assignment to @Christinadobrzyn (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
We think that this bug might be related to #vip-vsb
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Room - User details page can't be opened from members list
We are toggling user when onSelectRow
is called.
https://github.com/Expensify/App/blob/59741d821263569f72a8c6a6ab7c03825e7acda4/src/pages/RoomMembersPage.tsx#L302
Instead of toggling the use when onSelectRow
is called, we should use onCheckboxPress
to toggle user and use onSelectRow
for opening members details page like we do in ReportParticipantsPage
.
https://github.com/Expensify/App/blob/59741d821263569f72a8c6a6ab7c03825e7acda4/src/pages/ReportParticipantsPage.tsx#L290-L300
I think all users can access the participants details page but we can confirm the behaviour before implementing.
const openMemberDetails = useCallback((item: ListItem) => {
Navigation.navigate(ROUTES.PROFILE.getRoute(item?.accountID ?? ''));
}, []);
I don't really understand how the expected and actual results are associated with the video. I'm going to ask the team for some clarifications on what is expected here.
https://expensify.slack.com/archives/C066HJM2CAZ/p1723565856002269
This will be resolved with https://github.com/Expensify/App/issues/46838 and PR https://github.com/Expensify/App/pull/47201.
I'm going to add a HOLD to this so we can test and make sure it's working as expected after https://github.com/Expensify/App/pull/47201 is deployed.
monitoring PR - https://github.com/Expensify/App/pull/47201
monitoring PR - https://github.com/Expensify/App/pull/47201
monitoring PR - https://github.com/Expensify/App/pull/47201
Heads up that I'll be ooo 9/4 - 9/10. I'm not going to assign a new BZ teammate to this as we're working on the PR. If you need a BZ teammate, please ping in slack.
monitoring PR - https://github.com/Expensify/App/pull/47201
monitoring PR - https://github.com/Expensify/App/pull/47201
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.19-9 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2654638 Issue reported by: Applause Internal Team
Action Performed:
Precondition: #room conversation with at least 2 users, one that has a custom avatar and the other has a default avatar
Expected Result:
In the conversation viewer, when clicking on the avatar of any of the users, a modal with the user information should display. When interacting the avatar inside the user details modal, a full size view of the avatar should display.
Actual Result:
Clicking on user avatar leads to user select/unselect. User details page is not opened.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/e6a12390-0d8a-455f-bbad-5b1a4f7b0f21
View all open jobs on GitHub