Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[AWAITING PAYMENT][$250] [3rd Party Feeds] Card Assignment Flow #47377

Closed robertjchen closed 2 weeks ago

robertjchen commented 2 months ago

Part of the Third Party Workspace Feeds project

Main issue: https://github.com/Expensify/Expensify/issues/394008 Doc section: Doc Link Project:

Feature Description

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021845999902674751168
  • Upwork Job ID: 1845999902674751168
  • Last Price Increase: 2024-10-15
Issue OwnerCurrent Issue Owner: @
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

joekaufmanexpensify commented 2 months ago

I'm working with this Robert on this project, but I don't need to be assigned to every frontend new feature issue, as the work here is just regular BZ management. Going to revert back to the chosen auto-assignee!

joekaufmanexpensify commented 2 months ago

@jliexpensify , as an fyi @narefyev91 and @koko57 are working on this, and as soon as they comment, you'll be able to assign them! Setting to daily as this is deliverable by September 9th, 2024

melvin-bot[bot] commented 2 months ago

@jliexpensify Huh... This is 4 days overdue. Who can take care of this?

jliexpensify commented 2 months ago

Bump @narefyev91 and @koko57 to comment please

narefyev91 commented 2 months ago

I'm Nicolay from Callstack - will work on this issue

koko57 commented 2 months ago

I will work on the Card Assignment Flow and Card List

jliexpensify commented 2 months ago

Thanks, assigned both of you

koko57 commented 2 months ago

I'm starting working on Card Assignement flow, tomorrow I'll be focusing mainly on this issue.

VickyStash commented 2 months ago

Hi! I'm going to help @koko57 with Card List implementation here

koko57 commented 2 months ago

Still working on Card Assigment Flow, I'm halfway through the process.

joekaufmanexpensify commented 2 months ago

TY for the update!

VickyStash commented 2 months ago

Updates: Continue to work on the Cards List page implementation. I think I should be able to open the PR tomorrow if nothing unexpected comes up.

joekaufmanexpensify commented 2 months ago

Assigned @allroundexperts as they're going to review PRs here

koko57 commented 2 months ago

Most of the work is done for Card Assignement Flow, but I still have a few things to do there. I'm not sure if I'll be able to open the PR today, but I'll do my best to open it no later than tomorrow.

VickyStash commented 2 months ago

Updates:

VickyStash commented 2 months ago

The Company Cards List PR is ready for the review

koko57 commented 2 months ago

PR for Card Assignment Flow is opened https://github.com/Expensify/App/pull/48278 although I need to test it on the mobile devices. I think it would be good to merge https://github.com/Expensify/App/pull/48176 first

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

allgandalf commented 1 month ago

Can i get assigned for payment here please 🙏, I reviewed the PR

jliexpensify commented 1 month ago

@allgandalf can you add you Upworks name to your GH profile please?

allgandalf commented 1 month ago

@jliexpensify , I have shared it over DM on slack, thanks 🙏

jliexpensify commented 1 month ago

@joekaufmanexpensify @yuwenmemon can you confirm these amounts are correct for PR reviews?

https://www.upwork.com/jobs/~021845999902674751168

joekaufmanexpensify commented 1 month ago

Yeah, I think that is the correct payments for the issue. We should issue them after all PRs on the issue are merged, and have been in production for 7 days.

melvin-bot[bot] commented 4 weeks ago

This issue has not been updated in over 15 days. @yuwenmemon, @VickyStash, @koko57, @narefyev91, @allroundexperts, @jliexpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

jliexpensify commented 4 weeks ago

It looks like we might be waiting on https://github.com/Expensify/App/pull/48278 to hit Prod.

Just a heads up - I am OOO from the 3rd to 14th. I'll keep this assigned to myself though, I don't think any payments will need to be done during this period.

allgandalf commented 3 weeks ago

@jliexpensify can you please release the payment for this issue 🙏

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021845999902674751168

melvin-bot[bot] commented 2 weeks ago

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

jliexpensify commented 2 weeks ago

Upworks job and Payment Summary here

jliexpensify commented 2 weeks ago

Invited @allgandalf

jliexpensify commented 2 weeks ago

@allgandalf - is a checklist needed?

allgandalf commented 2 weeks ago

@allgandalf - is a checklist needed?

No, this issue belongs to a project so regression testing are provided at the end of the project

jliexpensify commented 2 weeks ago

Paid and job closed!