Closed lanitochka17 closed 5 days ago
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 2
Edited by proposal-police: This proposal was edited at 2024-08-14 13:28:19 UTC.
Track tax feature is still available when Taxes feature is disabled offline
We are using isDistanceTrackTaxEnabled
to determine if we should display tax features for
When user disable tax rate in offline mode, we are not optimistialy updating isDistanceTrackTaxEnabled (policy?.customUnits.customUnitID.customUnit?.attributes?.taxEnabled)
to false as we do for isPolicyTrackTaxEnabled (policy?.tax?.trackingEnabled)
We should check also for isPolicyTrackTaxEnabled
in the above places where we are using isDistanceTrackTaxEnabled
, since isPolicyTrackTaxEnabled
updated optimistically.
<Switch
isOn={isDistanceTrackTaxEnabled && isPolicyTrackTaxEnabled}
We will do the same for tax rates, and tax reclaimable as well
We can optimistially update isDistanceTrackTaxEnabled (policy?.customUnits.customUnitID.customUnit?.attributes?.taxEnabled)
to false (enabled)
in optimistic data, and to true (!enalbled)
in failure data here
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
value: {
customUnits: {
[customUnitID]: {
...customUnit,
attributes: {
...customUnit.attributes,
taxEnabled: customUnit.attributes.taxEnabled ? enabled : customUnit.attributes.taxEnabled,
},
},
},
tax: {
trackingEnabled: enabled,
We check for customUnit.attributes.taxEnabled
to prevent assigning true to isDistanceTrackTaxEnabled
and enabling Track Tax
feature when the user enables tax rate on more features page but didn't enable Track Tax on DistanceRatesSettings page
Job added to Upwork: https://www.upwork.com/jobs/~0125dfa57845b9c94e
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External
)
As taxes must be enabled on the policy in order to enable tax tracking on distance rates @etCoderDysto's proposal LGTM. πππ C+ reviewed
Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@Ollyws, @lschurr, @mountiny Eep! 4 days overdue now. Issues have feelings too...
@mountiny - looks like we just need a quick check from you. Can I assign this over to @etCoderDysto?
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
Assigned, thanks for your patience
π£ @etCoderDysto π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
@Ollyws PR is ready for review
Due for payment tomorrow @lschurr, Thanks!
Payment summary:
Requested on ND.
$250 approved for @Ollyws
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.20-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
When disabling Taxes feature offline Step 9 - Track tax switch should be disabled and locked Step 11 - Tax rate and Tax reclaimable on fields should disappear
Actual Result:
When disabling Taxes feature offline Step 9 - Track tax switch is enabled and locked Step 11 - Tax rate and Tax reclaimable on fields are still present
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/bb5ff826-f161-4a92-bd85-39379f58a489
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Ollyws