[$250] Approvers - Expenses are added to the already submitted report before it is approved

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4857763 Email or phone of affected tester (no customers): fischer9966+081424aemp@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition:

1. Login as the admin and create Collect workspace
2. Navigate to the collect workspace settings > More features > Enable workflows
3. Navigate to workflows > Enable Approvals
4. Enable delay submissions and set it to Manually
5. Invite a new user with Gmail account as an employee

Steps:

1. Login as the employee account in ND
2. Navigate to the workspace chat
3. Submit expense to the workspace for >100$
4. Tap "Submit" button
5. Submit another expense to the workspace

Expected Result:

A new expense is added to a new report, since the previous one has already been submitted

Actual Result:

A new expense is added to the already submitted report. Creation of a new report is possible only after approval of the previous one.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/4bf0166e-1c47-4e1c-942f-d6b6872d22fe

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831342357487627692
• Upwork Job ID: 1831342357487627692
• Last Price Increase: 2024-09-18

Issue Owner

Current Issue Owner: @paultsimura

[melvin-bot[bot]]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot[bot]]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

Reviewing today!

[melvin-bot[bot]]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

@Beamanator this was the issue we were chatting through in control, right? I think we have a solve here?

[Beamanator]

Hmmm honestly not sure if i agree, since this was report in Collect? But would be good to test if it happens in both!

It's still possible this has something to do with the recent "Instant submit for Control" changes

• cc @youssef-lr @neil-marcellini @cristipaval

[melvin-bot[bot]]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021831342357487627692

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[melvin-bot[bot]]

@paultsimura, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[paultsimura]

Bumped in Slack

[trjExpensify]

I'm pretty sure this came up somewhere in #wave-control recently with the changes to who can edit processing reports, I think @youssef-lr was working on it?

[dylanexpensify]

Ah yeah, agree - Advanced Approvals, we can move there!

[paultsimura]

I cannot reproduce this one 🤔

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@paultsimura @dylanexpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[dylanexpensify]

@izarutskaya can you reproduce?

[melvin-bot[bot]]

@paultsimura, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[izarutskaya]

I'll check and come back

[izarutskaya]

Not reproduced now Build v9.0.35-0

https://github.com/user-attachments/assets/8c8894cb-fdee-4202-b1aa-a4bf95517b7b

[melvin-bot[bot]]

@paultsimura, @dylanexpensify Still overdue 6 days?! Let's take care of this!

[paultsimura]

@dylanexpensify can we close based on https://github.com/Expensify/App/issues/47426#issuecomment-2351784240?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸