[$250] Update beginningOfChatHistory for certain cases with fresh copy

[jamesdeanexpensify]

Problem

New users often write in confused about how to use New Expensify. Key points of confusion still seem to be “How do I submit expenses?” or “How do I use this?” or are just unclear why they are looking at a chat platform. They then become frustrated or just leave us all together.

Solution

Update the beginningOfChatHistory copy in all rooms to be clearer and more concise, as well as remove any noise around features that don’t lead to conversion.

P/S is also here in Slack.

Copy updates

Type	Current example	Proposed copy
Concierge	This is the beginning of your chat with Concierge.	This chat is with Concierge. Ask questions and get 24/7 realtime support.
DM (aka beginningOfChatHistory)	This is the beginning of your chat with Daniel Vidal. You can also use the + button to split an expense, submit an expense, pay expenses, or assign a task!	This chat is with [recipient]. Use the + button to split, submit, or pay an expense.
Group chat (can’t find this in the code)	This is the beginning of your chat with Anu, Daniel and James.	This chat is with [recipients that don't include you]. Use the + button to split an expense.
Workspace chat (aka beginningOfChatHistoryPolicyExpenseChat)	Collaboration between James Dean (Marketing/PR) and NewDot Test - Expensify US starts here! 🎉 This is the place to chat, submit expenses and settle up. You can also use the + button to split an expense, submit an expense, track an expense, or assign a task!	This is where [submitter] will submit expenses to the [workspaceName] workspace. Just use the + button.
#announce room (aka beginningOfChatHistoryAnnounceRoom)	Collaboration between all Expensify's Workspace 6 members starts here! 🎉 Use #announce to chat about anything Expensify's Workspace 6 related.	This chat is with everyone in the [workspaceName] workspace. Use it for the most important announcements.
#admins room (aka beginningOfChatHistoryAdminRoom)	Collaboration among james@expensify.com Small Business Expo admins starts here! 🎉 Use #admins to chat about topics such as workspace configurations and more.	This chat is with [workspaceName] workspace admins. Use it to chat about workspace setup and more.
Domain room (aka beginningOfChatHistoryDomainRoom)	Collaboration with everyone at #expensify.com starts here! 🎉 Use #expensify.com to chat with colleagues, share tips, and ask questions.	This chat is with all Expensify members on the [domain] domain. Use it to chat with colleagues, share tips, and ask questions.
User-created room (aka beginningOfChatHistoryUserRoom)	Collaboration starts here! 🎉 Use this space to chat about anything #bravo-clubhouse related.	This chat room is for anything #[roomName] related. It was created by [displayName].
Invoice room (aka beginningOfChatHistoryInvoiceRoom)	Collaboration starts here! 🎉 Use this room to view, discuss, and pay invoices.	This chat is for invoices between [invoice sender/bill payer workspaceName] and [invoice/paid bill receiver workspaceName OR displayName]. Use the + button to send an invoice.

[danielrvidal]

@jamesdeanexpensify, what do you think is still needed for this? Just to get an engineer to pick it up or do we need to keep fleshing out the proposal?

[jamesdeanexpensify]

Just left you a comment in the doc, and then it would be great to get an engineer to pick it up and ask any remaining questions. I just thought you wanted to wait to house it under the F1 deadline.

[jamesdeanexpensify]

@danielrvidal I think this is ready for an engineer whenever!

[danielrvidal]

@jamesdeanexpensify now that this is in a whatsnext room/project, I imagine you should be able to recruit an engineer. I'm going to drop an update in the room but I think you should be good to go.

[jamesdeanexpensify]

Posted here as a next step!

[jamesdeanexpensify]

Renewed the convo here.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021831355584440701165

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[mariapeever]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update beginningOfChatHistory for certain cases with fresh copy #47427

What is the root cause of that problem?

Current copy is not clear enough for new Expensify users.

What changes do you think we should make in order to solve the problem?

Update the current copy to match the proposed copy. Updates to the language file (en.ts):

• [ ] Concierge - add a beginningOfChatHistoryConcierge property specific for Concierge just before beginningOfChatHistory.

• [ ] DM (aka beginningOfChatHistory) - update the beginningOfChatHistory property and add a participantNames param.

• [ ] Group chat - Count the participants' names for a group chat and re-use the beginningOfChatHistory property https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L603 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L530-L555

• [ ] Workspace chat (aka beginningOfChatHistoryPolicyExpenseChat) - Combine the beginningOfChatHistoryPolicyExpenseChat parts 1-3 into 1 and add parameters for participantName and policyName.

  • beginningOfChatHistoryPolicyExpenseChatPartOne
    • beginningOfChatHistoryPolicyExpenseChatPartTwo
    • beginningOfChatHistoryPolicyExpenseChatPartThree https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L604-L606 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L508-L513

• [ ] #announce room (aka beginningOfChatHistoryAnnounceRoom) - Combine the beginningOfChatHistoryAnnounceRoom parts 1-2 into 1 with a parameters for workspaceName and reportName.

  • beginningOfChatHistoryAnnounceRoomPartOne
    • beginningOfChatHistoryAnnounceRoomPartTwo https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L597-L599 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L582-L584

• [ ] #admins room (aka beginningOfChatHistoryAdminRoom) - Combine the beginningOfChatHistoryAdminRoom parts 1-2 into 1 with a parameters for workspaceName and reportName.

  • beginningOfChatHistoryAdminRoomPartOne
    • beginningOfChatHistoryAdminRoomPartTwo https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L595-L596 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L580-L581

• [ ] Domain room (aka beginningOfChatHistoryDomainRoom) - Combine the beginningOfChatHistoryDomainRoom parts 1-2 into 1 with a parameter for domainRoom.

  • beginningOfChatHistoryDomainRoomPartOne
    • beginningOfChatHistoryDomainRoomPartTwo https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L593-L594 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L576-L578

• [ ] User-created room (aka beginningOfChatHistoryUserRoom) - Combine the beginningOfChatHistoryUserRoom parts 1-2 into 1 with a parameter for reportName.

  • beginningOfChatHistoryDomainRoomPartOne
    • beginningOfChatHistoryDomainRoomPartTwo https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L593-L594 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L588-L591

• [ ] Invoice room (aka beginningOfChatHistoryInvoiceRoom) - Edit the beginningOfChatHistoryInvoiceRoom property and add params for invoice sender/bill payer workspaceName and invoice/paid bill receiver workspaceName OR displayName

  • beginningOfChatHistoryInvoiceRoom https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/languages/en.ts#L602 https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L585-L587

https://github.com/Expensify/App/blob/dc1407a56bfe70ee72e471c3733da9faa552590c/src/libs/SidebarUtils.ts#L593

What alternative solutions did you explore? (Optional)

N/A

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update beginningOfChatHistory for certain cases with fresh copy

What is the root cause of that problem?

This is a new feature

What changes do you think we should make in order to solve the problem?

• concierge chat, we can create a new translation for this one as per the description above or we can still use beginningOfChatHistory and create a new translation text for the additional text Ask questions and get 24/7 realtime support. and add it here if the report is concierge.

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/components/ReportWelcomeText.tsx#L178

• DM chat and group chat, we can update beginningOfChatHistory translation as the description to This chat is with and then update usePlusButton to \nUse the + button to ${additionalText}, or assign a task!

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/languages/en.ts#L603

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/languages/en.ts#L613

OPTIONAL: We can remove or assign a task text.

• Policy expense chat: update three phrase beginningOfChatHistoryPolicyExpenseChat translations as the description

beginningOfChatHistoryPolicyExpenseChatPartOne: 'This is where ',
beginningOfChatHistoryPolicyExpenseChatPartTwo: ' will submit expenses to the ',
beginningOfChatHistoryPolicyExpenseChatPartThree: ' workspace. Just use the + button.',

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/languages/en.ts#L604-L607

• Admin room and announce room: Update two phrase of the beginningOfChatHistoryAnnounceRoom translation and beginningOfChatHistoryAdminRoom as the description

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/languages/en.ts#L595-L599

• Domain room: Update the beginningOfChatHistoryDomainRoom translation as the description with domain param is the report.reportName

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/languages/en.ts#L593-L594

• User-created room: Update two phrases the beginningOfChatHistoryUserRoom translation as the description

https://github.com/Expensify/App/blob/cb2bdf28addd44c3f0c265f55b8df948c2f9cfc8/src/languages/en.ts#L600-L601

• Invoice room: Update the beginningOfChatHistoryInvoiceRoom translation as the description with two extra params invoice sender/bill payer workspaceName is the display name of the user that is invited to the invoice room and invoice/paid bill receiver workspaceName OR displayName is the display name user that creates the send invoice or the workspace name of the workspace that we create the send invoice.

For all translations, we should update the all places that we use this translation if the param is changed.

We need to make sure that the beginningOfChatHistory never gets replaced by a custom roomDescription if someone sets one. The roomDescription will instead be included/updated elsewhere (in the subheader).

We already have handled this in getRoomWelcomeMessage function

What alternative solutions did you explore? (Optional)

[AsfandSoomro]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update beginningOfChatHistory for certain cases with fresh copy

What is the root cause of that problem?

Chat header message is not clear to new users

What changes do you think we should make in order to solve the problem?

First of all we need to re-code all beginningOfChatHistory(all) data in reportActionsView object in a clear and consistent way. They all need to accept arguments if they need dynamic message so we can pass (e.g workspace name, recipient name, or multiple recipients names etc) rather than the current PartOne PartTwo PartThree different keys. This will be more flexible and easier to change the message in future. Something like this: welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Welcome to ${roomName}!`,

Files that will be affected

• src/languages/en.ts
• src/languages/es.ts
• src/libs/SidebarUtils.ts

My approach to solve the problem

• For Concierge create new key beginningOfChatHistoryConcierge in reportActionsView it won't accept any parameters, just static message. And in getWelcomeMessage() function figure out if the recipient name is Concierge since we don't have a Report util function like this ReportUtils.isSelfDM(report) to check if user is in chatroom with Concierge.
• For DM same key remains, just dynamic.
• For Group Chat new dynamic key beginningOfChatHistoryGroupChat. And in getWelcomeMessage() figure out the way to remove the name of the client user before the recipients names message constructor loop.

Similar approach in all others. This way I think messages will be more flexible and easy to change in future as well.

P.S I have only explored Expensify code now and have not contributed to Open Source before. Still reading the contribution.md file

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

📣 @AsfandSoomro! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[AsfandSoomro]

Contributor details Your Expensify account email: asfandsoomro13@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~0184a98fdca35057cc

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ikevin127]

Given this is a copy update issue I'd say we can go with the first come, first served method here and assign @mariapeever based on the posted proposal given the RCA is obvious and the solution is straight-forward.

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @mariapeever You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[ikevin127]

👋 Hey @mariapeever, please leave a comment letting us know when we can expect a PR to be ready for review 🧑‍💻

Otherwise, if there's no response in ~48h (2 days) from time of assignment (https://github.com/Expensify/App/issues/47427#issuecomment-2332987965, 1 day already passed) we'll have to reassign the task to the contributor next in line, as per the guidelines (if I recall correctly).

[!note] If you have any questions regarding your first assignment, how does this work, or any other information feel free to ask.

@roryabraham Please correct me if the 'no response' rule has different timelines as I wasn't able to find info on this specific case.

[mariapeever]

@ikevin127 I have submitted a proposal on Upwork and have been waiting for it to get approved. I can submit a PR by the end of today.

[ikevin127]

@mariapeever Thanks for getting back. I understand the worry of contributing for the first time, allow me to explain how the process works:

1. Contributor posts proposal.
2. Proposal is selected (your case here).
3. If contributor contributes for the first time, they have to apply to the Upwork job because they are not in the offer sending automation system yet (first job).
4. Contributor opens PR, pr is reviewed and if all good - merged.
5. PR will be deployed to staging and QA runs tests.
6. If no issues are reported, PR gets deployed to production ~1-2 days after staging deploy.
7. As soon as PR hits production, a 7-day regression period ensues and a HOLD for Payment {date} is added to the issue's title.
8. If no issues are reported at the end of the 7-day regression period, a BZ tram member will issue the payment for both Contributor and C+ | so you will get paid, no worries - it just has to follow this process.

[!note] In case at any stage of the deploy process, a regression is found coming from the deployed PR changes, the issue's bounty will be cut in half (-50%) for both controbutor and C+, and the regression period extends to when the follow-up fix PR is deployed to production.

[mariapeever]

@ikevin127 Thanks! Does this mean that I can create a PR before my Upwork proposal has been approved?

[ikevin127]

@mariapeever For sure, as mentioned - when the payment is due date, the BZ team member which handles the payments will make sure you accept your offer and you get paid.

Given the whole deploy and 7-days regression period process can take several days, the sooner the PR is opened, the better - but keep in mind that rushing to open the PR can lead to regressions if not tested thoroughly.

[ikevin127]

@mariapeever Any updates on the PR or whether you plan on working on this issue ? Asking because there's been 7+ days from assignment and we're looking at fixing this issue. Please let us know!

[ikevin127]

⌛ I think we should consider moving on with the 2nd proposal and assign @nkdengineer as contributor since they are the next in line. @roryabraham @jamesdeanexpensify What do you think ?

[mariapeever]

@ikevin127 Sorry for the delay. I was busier than usually the last few days. I will create a PR today.