Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

Html codes appear in the SMS when a new member joins domain #47465

Open m-natarajan opened 1 month ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.20-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723333080242499

Action Performed:

  1. Create an SMS account > set the display name and include an apostrophe (e.g David's SMS)
  2. Add the SMS account as a domain admin of a private domain
  3. Sign up for an account on that domain and validate the account when prompted
  4. Observe the SMS received by the domain admin

Expected Result:

There shouldn't be any HTML codes in the SMS

Actual Result:

`Hiya David's!

I just wanted to let you know that dbarrett+ghfhhh66@quinthar.com has created an Expensify account. They have been added to your default Domain Group on the "quinthar.com" domain.`

Additionally Messages are showing as sent from 4777

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

IMG_1075 (1)

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

trjExpensify commented 1 month ago

Easily reproducible. Clarified in the steps that you need a display name with an apostrophe.

IMG_0547

Definitely going to be Internal. Adding to #wave-control as polish, where we'll be building domains support.

melvin-bot[bot] commented 3 weeks ago

Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 3 weeks ago

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

trjExpensify commented 3 weeks ago

@dylanexpensify putting on your radar for hot picks shoutout!

melvin-bot[bot] commented 3 weeks ago

Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 2 weeks ago

this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 2 weeks ago

Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 2 weeks ago

Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 1 week ago

10 days overdue. Is anyone even seeing these? Hello?

melvin-bot[bot] commented 1 week ago

12 days overdue now... This issue's end is nigh!

marcaaron commented 1 week ago

I see the problem and I'm raising a fix now.

melvin-bot[bot] commented 2 hours ago

@marcaaron Eep! 4 days overdue now. Issues have feelings too...