Open IuliiaHerets opened 1 month ago
Triggered auto assignment to @jliexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
We think that this bug might be related to #wave-collect - Release 1
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Job added to Upwork: https://www.upwork.com/jobs/~0191bfdce4cbe61eaa
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External
)
I can repro - essentially, when we use the Workspace switcher a second time, it should default to the newly created workspace. Is that correct @IuliiaHerets?
Workspace switcher - Filter is not consistently applied when creating workspace from switcher
Before navigating we are not checking if the activeWorkspaceID
is undefined or not.
https://github.com/Expensify/App/blob/65a3811ea62ec073d44b4d2558e053183ad76ee8/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx#L86-L100
We can pass undefined when activeWorkspaceID
is undefined.
Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest, policyIDs: policy && activeWorkspaceID ? currentSearchParams?.policyIDs : undefined}));
We can always use activeWorkspaceID
for policyIDs
.
I am not able to reproduce it on latest main
Bump @shubham1206agra to double-check if this can still be reproduced + proposal reviews, thanks!
@jliexpensify, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...
Bumping @shubham1206agra again
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@jliexpensify, @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Hi @shubham1206agra - bump on this! Will also DM you.
Hello, I wanted to point out that I have a PR ready that will significantly change how filtering by policyID will work: https://github.com/Expensify/App/pull/47787
I'd suggest to do no work on this bug until ☝️ PR is merged, and most likely this bug will be fixed.
@jliexpensify, @shubham1206agra 10 days overdue. I'm getting more depressed than Marvin.
@jliexpensify Please put this issue on hold as per https://github.com/Expensify/App/issues/47482#issuecomment-2310211048
Done!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.20-6 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The workspace switcher filter should be consistent when selecting a workspace and creating a new workspace from the workspace switcher.
Actual Result:
In Step 8. after creating a new workspace from the workspace switcher, the filter resets to Expensify. The filter is not reset in Search page in Step 10. When returning from Search to Inbox (Step 12), the filter reverts to the one selected in Step 3.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/ee91535e-b6e6-4719-ab5f-0959e91bdb9a
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @shubham1206agra