[$250] Chat - Copy to clipboard & pasting phone number, shows @expensify.sms after number

IuliiaHerets commented 4 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.20 Reproducible in staging?: Y Reproducible in production?: Y Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/home
Tap on a report
Enter eg : @+919878675645
Send the message
Long press the message and copy to clipboard
Tap plus icon -- assign task
Paste in title field

Expected Result:

Copy to clipboard and pasting phone number, must not show @expensify.sms after number.

Actual Result:

Copy to clipboard and pasting phone number, shows @expensify.sms after number.

Workaround:

Unknown

Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/38faca5c-1151-446e-a781-fb6785ea218d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e408113871c83775
Upwork Job ID: 1827401422870562005
Last Price Increase: 2024-08-24
Automatic offers:

ZhenjaHorbach | Reviewer | 103688903
FitseTLT | Contributor | 103688906

Issue Owner

Current Issue Owner: @ZhenjaHorbach

melvin-bot[bot] commented 4 weeks ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 4 weeks ago

We think that this bug might be related to #vip-vsb

IuliiaHerets commented 4 weeks ago

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

FitseTLT commented 4 weeks ago

Edited by proposal-police: This proposal was edited at 2024-08-15 11:38:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy to clipboard & pasting phone number, shows @expensify.sms after number

What is the root cause of that problem?

We forgot to remove sms domain for the text here https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L52-L53 and htmlToText by default doesn't remove sms domains

What changes do you think we should make in order to solve the problem?

We need to update our expensify-common lib, that is, we need to remove sms domain for htmlToText case same as we do for htmlToMarkdown here So we need to change code here to

                    return `@${Str.removeSMSDomain(extras.accountIDToName?.[g1]?? '') }`;

What alternative solutions did you explore? (Optional)

We need to remove the sms domain

function setClipboardMessage(content: string) {
    if (!Clipboard.canSetHtml()) {
        Clipboard.setString(Str.removeSMSDomain(Parser.htmlToMarkdown(content)));
    } else {
        const anchorRegex = CONST.REGEX_LINK_IN_ANCHOR;
        const isAnchorTag = anchorRegex.test(content);
        const plainText = isAnchorTag ? Parser.htmlToMarkdown(content) : Parser.htmlToText(content);
        Clipboard.setHtml(content, Str.removeSMSDomain(plainText));
    }
}

or only apply the removing to htmlToText cases as htmlToMarkdown properly removes the sms domain alternatively We can also take the cleaning code to Clipboard.setHtml and setString

melvin-bot[bot] commented 3 weeks ago

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 3 weeks ago

@kevinksullivan Still overdue 6 days?! Let's take care of this!