Open lanitochka17 opened 3 weeks ago
Triggered auto assignment to @twisterdotcom (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
Email address can be selected which leads to infinite loading in Category page
We are not passing canInviteUser as false for action === CONST.IOU.ACTION.CATEGORIZE
https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L162-L163
canInviteUser: action !== CONST.IOU.ACTION.CATEGORIZE,
I also recommend changing text label when action is categorize as we can't search for email and phone
https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L437
Additionally we need to avoid invalid email
or invalid phone
header message for categorize by updating getHeaderMessage
to have a new param shouldAvoidContactMessage
(we will pass as true for action type categorize) and avoid invalid phone/email message inside getHeaderMessage
https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L212-L217
Yeah weird bug.
Job added to Upwork: https://www.upwork.com/jobs/~01fdcfeaf864ee2ecb
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External
)
Categorize - Email address can be selected which leads to infinite loading in Category page
With distance request, categorize or share action, we don't want to display user option in the participant page.
When retrieving the default options, we already do that by passing param canInviteUser: canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction
in OptionsListUtils.getFilteredOptions
function:
https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L108
But when retrieving the filter options, we don't do the same: https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L158-L163
We should passing canInviteUser: canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction
in:
https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L158
Optionally, we can update: https://github.com/Expensify/App/blob/75f1729fc255df1792e37f9ad3e1b44d40d77f5b/src/libs/OptionsListUtils.ts#L2556 to:
userToInvite: canInviteUser ? userToInvite : null,
because the same was used in: https://github.com/Expensify/App/blob/75f1729fc255df1792e37f9ad3e1b44d40d77f5b/src/libs/OptionsListUtils.ts#L2085
Contributor details Your Expensify account email: visotecq@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01936ce33c6cefefe9?mp_source=share
Proposal
As described issue, we landed to the root cause of the infinite loading on Category due to following -
1) Entering E-mail without assigned to any Workspace , makes infinite Loading on the Category Page.
Solution -
1) On Entering E-mail if no Workspace pops up in List then on Clicking E-mail , create a New Workspace with that E-mail then Navigate to Category .
๐ฃ @visotecq! ๐ฃ Hey, it seems we donโt have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
@visotecq Please make sure you've read Contributing to Expensify and once you've understood everything, please format your comment according to the proposal template if you're interested in fixing this issue; otherwise, it won't be considered for review.
Additionally, to pass the bot verification, you need to submit a separate message rather than editing an existing one.
@eVoloshchak, @twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@eVoloshchak we still waiting on a good proposal here?
@FitseTLT's proposal looks good to me!
Additionally we need to avoid invalid email or invalid phone header message for categorize by updating getHeaderMessage to have a new param shouldAvoidContactMessage (we will pass as true for action type categorize) and avoid invalid phone/email message inside getHeaderMessage
We can work out the specifics of this on the PR stage, but I think we could use getHeaderMessageForNonUserList for this
๐๐๐ C+ reviewed!
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@eVoloshchak What is the feedback about my proposal above? Thanks
The selected solution does not fix the case distance request, categorize or share action and it is inconsistent with what we already had here: https://github.com/Expensify/App/blob/d4d5a2586910ff46147219ee3e98bb3e936f8037/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L108 cc @thienlnam
Yeah, I agree with that update
๐ฃ @daledah You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review ๐งโ๐ป Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing ๐
If you havenโt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.21-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
App should not show result for email address because categorizing is only for workspaces
Actual Result:
App shows result for email address and Category page loads infinitely after selecting the user
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/a024c2ee-7d7e-4348-8af6-876ebdadde05
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eVoloshchak