search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

[$250] WS switcher-Different back button behavior when creating workspace via + and Get started button #47603

Open IuliiaHerets opened 3 weeks ago

IuliiaHerets commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.21-4 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Open workspace switcher.
  3. Click + icon next to "Workspaces".
  4. Click app back button on workspace editor page.
  5. Note that app opens workspace switcher when returning from workspace editor after creating a workspace from workspace switcher.
  6. Delete the workspace.
  7. Go to Inbox.
  8. Open workspace switcher.
  9. Click Get started on "Create a workspace" modal.
  10. Click app back button on workspace editor page.

Expected Result:

App will open workspace switcher when clicking app back button after creating workspace from Create a workspace" modal (should display the same behavior as when the + button is used).

Actual Result:

App returns to Account settings instead.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/b6c6d620-376a-4c2e-8a41-e004ccafbd30

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013645bc6cec0aa80d
  • Upwork Job ID: 1828169605427820408
  • Last Price Increase: 2024-09-09
Issue OwnerCurrent Issue Owner: @mananjadhav
IuliiaHerets commented 3 weeks ago

We think that this bug might be related to #vip-vsb

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 3 weeks ago

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

etCoderDysto commented 3 weeks ago

Edited by proposal-police: This proposal was edited at 2024-08-21 13:09:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Different back button behavior when creating workspace via + and Get started button

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Following the same pattern used in WorkspaceCardCreateAWorkspace page, we shouldn't pass the active route (/workspace-switcher) to backTo param, and call createWorkspaceWithPolicyDraftAndNavigateToIt without any argument here. When there is no backTo param the else condition will execute -> then the modal will be closed -> and user will be navigated to workspace list page 

App.createWorkspaceWithPolicyDraftAndNavigateToIt();

What alternative solutions did you explore? (Optional)

JmillsExpensify commented 3 weeks ago

Hmm interesting. I agree that's inconsistent. I think this comes down to whether we should move UP on pressing back or now. @marcaaron thoughts on this consideration? I can kind of see the argument that UP is a more valid action, so you should always be taken back to the workspace list.

marcaaron commented 3 weeks ago

Not too passionate about this one as it's a pretty specific set of actions the user will take to uncover this inconsistency and can't imagine anyone feeling too impeded by either result. Both bring you to a list of workspaces. Both lead to the option to create a new workspace if you choose to do that after you just created one (which is probably an uncommon action in any case).

Ignoring the rules of navigation for a second - I see the workspace selector as less of a "page" and almost more of a pop up selector menu from a UX POV so it doesn't really need to be something we can navigate back to.

JmillsExpensify commented 3 weeks ago

Ignoring the rules of navigation for a second - I see the workspace selector as less of a "page" and almost more of a pop up selector menu from a UX POV so it doesn't really need to be something we can navigate back to.

Cool, I agree with this. So then let's make sure that "back" goes to the workspace list for both of these cases.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~013645bc6cec0aa80d

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

melvin-bot[bot] commented 1 week ago

@JmillsExpensify, @mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 week ago

@JmillsExpensify @mananjadhav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 week ago

@JmillsExpensify, @mananjadhav Still overdue 6 days?! Let's take care of this!

JmillsExpensify commented 1 week ago

Still waiting for proposals

etCoderDysto commented 1 week ago

I have a proposal here https://github.com/Expensify/App/issues/47603#issuecomment-2294986203

mananjadhav commented 1 week ago

Cool, I agree with this. So then let's make sure that "back" goes to the workspace list for both of these cases.

@etCoderDysto Couldn't understand from your proposals if it covers the expected behavior ^

etCoderDysto commented 6 days ago

Cool, I agree with this. So then let's make sure that "back" goes to the workspace list for both of these cases.

@etCoderDysto Couldn't understand from your proposals if it covers the expected behavior ^

@mananjadhav I have updated my proposal to cover the expected behaviour.

wildan-m commented 4 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS switcher: Different back button behavior when creating workspace using the + and Get started button.

What is the root cause of that problem?

Inconsistent call to createWorkspaceWithPolicyDraftAndNavigateToIt in WorkspaceCardCreateAWorkspace.tsx and src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

What changes do you think we should make in order to solve the problem?

I believe the back button should navigate to the previous route. Contrary to the previous suggestion, I suggest adding activeRoute to the createWorkspaceWithPolicyDraftAndNavigateToIt function call.

src/pages/workspace/card/WorkspaceCardCreateAWorkspace.tsx

                onPress={() => {
                    const activeRoute = Navigation.getActiveRouteWithoutParams();

                    interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt('', '', false, false, activeRoute)); 
                }}

Adding interceptAnonymousUser is optional, but I recommend including it to prevent other inconsistencies.

What alternative solutions did you explore? (Optional)

N/A

mananjadhav commented 3 days ago

Reviewing the proposals.

melvin-bot[bot] commented 2 days ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸