Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

Unavailable workspace displayed while waiting for API response #47633

Closed m-natarajan closed 1 week ago

m-natarajan commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1723133790546149

Action Performed:

  1. signing into accountA in #focus mode that is a member of a room that isn't currently read
  2. sending a message in the room from accountB while accountA is still open in another browser
  3. go offline in accountA
  4. open the room and see what the header shows

Expected Result:

Workspace name and loading skeleton for the content while it loads

Actual Result:

No loading skeleton and unavailable workspace displayed until response received form Chronos comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/c53d236a-ecdd-474b-a934-8d301a265de9

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Current assignee @puneetlath is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

melvin-bot[bot] commented 3 weeks ago

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

MelvinBot commented 3 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

muttmuure commented 3 weeks ago

I think we agreed that fixing issues with Chronos is out of scope for the NewDot Quality project: https://expensify.slack.com/archives/C05LX9D6E07/p1723207265131579

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @srikarparsi (AutoAssignerNewDotQuality)

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

muttmuure commented 3 weeks ago

I can see we agreed to fix this one however - here: https://expensify.slack.com/archives/C05LX9D6E07/p1724072534751829?thread_ts=1723133790.546149&cid=C05LX9D6E07

muttmuure commented 3 weeks ago

I don't think it's necessarily related to Chronos, just to chats that take a long time to deliver an API response

tsa321 commented 3 weeks ago

Maybe related to https://github.com/Expensify/App/issues/43656 because we decide to display the first message.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sakluger commented 2 weeks ago

I'm adding another BZ team members since I'll be OOO through 8/30.

Christinadobrzyn commented 2 weeks ago

Trying these reproduction steps in the Slack chat:

  1. signing into accountA in #focus mode that is a member of a room that isn't currently read
  2. sending a message in the room from accountB while accountA is still open in another browser
  3. go offline in accountA
  4. open the room and see what the header shows

(accountA c.dobrzyn+17@gmail.com & accountB c.dobrzyn+45@expensifail.com)

This seems to happen with Chats and Rooms when offline. Here's a video of both. Updated the OP with these testing steps. I think this is the issue? @srikarparsi do you agree?

https://github.com/user-attachments/assets/100ee6e8-55d6-4614-85c5-a198b6983a1c

srikarparsi commented 2 weeks ago

Hey @Christinadobrzyn! I’m not sure if I missed it but was there an unavailable workspace subtitle in the video? I’ll also try looking more into what could be causing this tomorrow

Christinadobrzyn commented 2 weeks ago

Hi @srikarparsi, no- I didn't see the unavailable workspace, but the skeleton showed when first testing. I just tested again and the skeleton doesn't show and I don't see the unavailable workspace either.

MelvinBot commented 2 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

srikarparsi commented 2 weeks ago

Got it, didn't get time to try to reproduce this today but will try to make time for this tomorrow

Christinadobrzyn commented 1 week ago

I'm still not able to get that error. I wonder if we should just ask QA to retest this again or close until it's more clear how to reproduce it?

sakluger commented 1 week ago

@Christinadobrzyn I don't think QA was ever able to reproduce this one.

@quinthar we're having a hard time reproducing the issue. Are you still seeing this issue in your account?

melvin-bot[bot] commented 1 week ago

@sakluger @srikarparsi @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

muttmuure commented 1 week ago

Can we amend the reproduction steps to:

  1. Enable 4G throttling
  2. Send a message to Chronos
  3. Before you get your response from Chronos open a room
melvin-bot[bot] commented 1 week ago

@sakluger, @srikarparsi, @Christinadobrzyn Eep! 4 days overdue now. Issues have feelings too...

Christinadobrzyn commented 1 week ago

heads up - I'm going to be ooo 9/4-9/11.

I tried these steps in browserstack Android and I can't reproduce the error. @muttmuure where are you getting the error in those steps? In the new room or in Chronos?

srikarparsi commented 1 week ago

We weren't able to reproduce this in the thread and I wasn't able to reproduce this locally either. I'm going to keep an eye on the thread to see if it gets reproduced but going to close this out for now.

https://github.com/user-attachments/assets/46123b86-b592-469e-934d-c126b59a08b5