Closed lanitochka17 closed 1 week ago
Triggered auto assignment to @twisterdotcom (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
The waypoint selector moves to the scan tab for a few seconds after a swipe
When we drag the waypoint we don't disable the swipe option of the tab navigator then the weird behavior happens
OnyxTabNavigator
should accept a new prop screenOptions
and DraggableList
accept a new prop onDragStart
In IOURequestStartPage
pass screenOptions
with swipeEnabled
to OnyxTabNavigator
here
const [swipeEnabled, setSwipeEnabled] = useState(true);
screenOptions={{
swipeEnabled,
}}
setSwipeEnabled
to IOURequestStepDistance
swipeEnabled
to false
and update it to true
when the drag ends.onDragEnd={(params) => {
updateWaypoints(params);
setSwipeEnalbed?.(true);
}}
onDragStart={() => {
setSwipeEnalbed?.(false);
}}
Simple pass screenOptions
to OnyxTabNavigator
with swipeEnabled
as false
if the selectedTab
is the distance tab
screenOptions={{
swipeEnabled: selectedTab !== CONST.TAB_REQUEST.DISTANCE,
}}
@twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Job added to Upwork: https://www.upwork.com/jobs/~01ebd6f4ddf963d9c7
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External
)
Niche, so downgrading.
Upwork job price has been updated to $125
@nkdengineer Thank you for the proposal. Unfortunately your main solution does not work in fixing the issue, check out the video below and my changes diff and let me know in case I did not apply the solution correctly.
https://github.com/user-attachments/assets/32742ca7-4a96-4aa4-847c-c13d7881b0fb
[!important] Make sure to test your implementation with
CONFIG.USE_REACT_STRICT_MODE
set tofalse
because this is how it will behave once on staging / production.
Regarding the alternative solution, the proposed change is not desirable in this case as we don't want to completely disable swiping between tabs while on the Distance request tab.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
I think there are two ways to go about this issue:
cc @twisterdotcom
Let's close. This is niche and obviously not super easy to fix. Thanks for the help @ikevin127.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.22-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): nathanmulugetatesting+1030@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The tab changes without any issues and the waypoint selector doesn't appear on the scan tab
Actual Result:
The waypoint selector moves to the scan tab for a few seconds after a swipe
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/328a617a-c403-4d8c-b3bb-0531e272d445
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ikevin127